Closed
Bug 1468533
Opened 7 years ago
Closed 7 years ago
Race condition throwing an error about $rootScope.repos in the console
Categories
(Tree Management :: Treeherder: Frontend, defect, P1)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: camd, Assigned: camd)
References
Details
Attachments
(1 file)
This is benign, but should be fixed. It was a result of moving away from lodash. Just needs an extra check.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → cdawson
Priority: -- → P1
|
||
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8985199 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3659
Dang, I missed this race condition prior to merge. My bad.
Attachment #8985199 -
Flags: review?(emorley)
|
||
Updated•7 years ago
|
Attachment #8985199 -
Flags: review?(emorley) → review+
|
||
Comment 3•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/7d85be70346aa51c35a712235d4e149c62d90487
Bug 1468533 - Fix race condition throwing an error about .repos (#3659)
This race condition was introduced in commit 8993966
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•