1468658 - Fix & enable ESLint quotes, spaced-comment, space-infix-ops & comma-dangle

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P1)

Description

[Ed Morley [:emorley]]

These are some of the lower hanging fruit rules that can be fixed using `--fix`.

Enabling these now will help reduce the amount of new code that is added, that deviates from the rules.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3665

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/fe4f377d31831b308c668a5605be5a64963ceae8
Bug 1468658 - Fix/enable eslint 'quotes'

https://eslint.org/docs/rules/quotes

Changes performed by `--fix`.

https://github.com/mozilla/treeherder/commit/3420c1685baf072a7a271d43edf95c2c54bb1592
Bug 1468658 - Fix/enable eslint 'spaced-comment'

https://eslint.org/docs/rules/spaced-comment

Changes performed by `--fix`.

https://github.com/mozilla/treeherder/commit/9ac0d2b8f912f067156d9172abb3deb0ecba8c6a
Bug 1468658 - Fix/enable eslint 'space-infix-ops'

https://eslint.org/docs/rules/space-infix-ops

Changes performed by `--fix`.

https://github.com/mozilla/treeherder/commit/3e31201ae8339881d8a10b70760a7cbae29a20a8
Bug 1468658 - Fix/enable eslint 'comma-dangle'

https://eslint.org/docs/rules/comma-dangle

Changes performed by `--fix`.

https://github.com/mozilla/treeherder/commit/8b11478b2813f615f8a244c7c668740bcb26d42c
Bug 1468658 - Enable eslint 'prefer-rest-params'

https://eslint.org/docs/rules/prefer-rest-params

https://github.com/mozilla/treeherder/commit/94100a23f0bf65df7f90b592653bcc01decfb5ae
Bug 1468658 - Remove redundant eslint-disable-line

Since the rule is disabled entirely in `lint.js` for now.