Closed Bug 1468671 Opened Last year Closed Last year

Tracking Protection in identity popup is broken for longer localizations

Categories

(Firefox :: Site Identity, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 62
Tracking Status
firefox61 --- unaffected
firefox62 --- verified

People

(Reporter: flod, Assigned: johannh)

References

Details

Attachments

(3 files)

Attached image italian.png
This is how it currently looks in Italian: the entire information about tracking protection being ON or OFF is missing, and OFF is DISATTIVA in Italian…
P.S. Ignore the typo if you can read Italian, it's already been fixed
Attached image italian2.png
One more issue (label for the button is overflowing).
Thanks for catching this. I hope just making things wrap will fix it 
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: -- → P1
So, making the text wrap unfortunately doesn't really seem to work with the flex model, I can't get the container to grow with its children as I want it to. Hence, I switched to using CSS Grid instead.
Comment on attachment 8985875 [details]
Bug 1468671 - Enable identity popup headlines to span multiple lines.

Maybe I'm missing something, but can't you just use the box model and set flex="1" on the labels and maybe align="center" on the container? Seems to work fine for me, although you may want to double check the desired element alignment.

I tested this patch and it is broken when the permissions header wraps.
Attachment #8985875 - Flags: review?(nhnt11)
Let me try that, thanks!
So I'm 95% sure I tried something like this earlier, probably missed some detail. It works now. Thank you for the suggestion, Paolo!
Comment on attachment 8985875 [details]
Bug 1468671 - Enable identity popup headlines to span multiple lines.

https://reviewboard.mozilla.org/r/251376/#review258596

::: browser/components/controlcenter/content/panel.inc.xul:60
(Diff revision 2)
>        <!-- Tracking Protection Section -->
>        <hbox id="tracking-protection-container"
>              class="identity-popup-section"
>              when-connection="not-secure secure secure-ev secure-cert-user-overridden file">
>          <vbox id="tracking-protection-content" flex="1">
>            <hbox class="identity-popup-preferences-button-container">

Remove the two instances of the unused "identity-popup-preferences-button-container" class.
Attachment #8985875 - Flags: review?(paolo.mozmail) → review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6fd500bb5dd8
Enable identity popup headlines to span multiple lines. r=Paolo
https://hg.mozilla.org/mozilla-central/rev/6fd500bb5dd8
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
QA Whiteboard: [good first verify]
Reproduced this bug on an older Nightly it build 62.0a1 (2017-06-13) using the attachment from comment 0 and comment 2.

I can confirm that this bug is verified fixed, on latest Beta it 62.0b5 (20180702164905) on Mac OS X 10.11.6.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.