1468673 - Widen the window of time that ScriptPreloader notes and caches scripts

Status: NEW

(Core :: XPConnect, enhancement, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

In bug 1458375, I hacked around a race condition where the ScriptPreloader could receive script information from content processes after the cache had been written (therefore throwing out the content process script information).

I did this by delaying the point where the cache is written out until the browser-idle-startup-tasks-finished observer notification.

Originally, I wanted to keep noting scripts in the parent process until browser-idle-startup-tasks-finished fired, but in doing so, I seemed to hit ts_paint regressions on Linux 64.

We should revisit this - it's probably to our advantage to cache as many early scripts as possible via the ScriptPreloader.

Comment 1

[Andrew Overholt [:overholt]]

I apparently like to needinfo kmag about things with the ScriptPreloader so I don't want to break that tradition now :)

Comment 2

[Kris Maglione [:kmag]]

We already discussed this