1468678 - Exiting Responsive Design Mode does not re-enable autoscrolling

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Yuri Khan]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180602171201

Steps to reproduce:

0. In Preferences | General | Browsing, enable [x] Use autoscrolling.
1. Open a page long enough to have a scrollbar.
2. Middle-click in the page. Observe that autoscrolling is triggered. Click again to stop scrolling.
3. Press Ctrl+Shift+M to go into Responsive Design Mode.
4. Middle-click in the page. Observe that autoscrolling is not triggered.
5. Press Ctrl+Shift+M again to exit Responsive Design Mode.
6. Middle-click in the page. Observe that autoscrolling is not triggered.
7. Reload the page, or navigate to a different page in the same tab. Observe that autoscrolling is no longer triggered in this tab no matter what you do.



Expected results:

At least in steps 6 and 7, after Responsive Design Mode is canceled, autoscrolling should have kicked in again.

Comment 1

[Peter Magyari (Desktop QA)]

I have managed to reproduce this issue on Firefox 62.0a1 (2018-06-18) (64-bit) nightly
Firefox  61.0b14 (64-bit) beta and Firefox  60.0.2 (64-bit) release on Windows 10 and macOS 10.13.
Auto-scrolling does not trigger in Responsive Design Mode even after it is canceled.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Thanks for reporting! I wasn't aware of this autoscrolling feature until now. :) I was able to reproduce the issue.

I believe it should be straightforward to fix.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1468678 - Allow autoscrolling with RDM.

Review commit: https://reviewboard.mozilla.org/r/252086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252086/

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c17118843a10f882c3909f380fb888464fafdb9b

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In related news, I filed bug 1470235 to attempt tunneling messages by default to avoid future issues like this.)

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 8986836 [details]
Bug 1468678 - Allow autoscrolling with RDM.

https://reviewboard.mozilla.org/r/252086/#review258560

I didn't knew about this feature either!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eecfdc7799ca
Allow autoscrolling with RDM. r=ochameau

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/eecfdc7799ca

Comment 10

[Rares Doghi, Desktop QA]

Hi, this issue no longer occurs on Firefox Release 64.0 and Nightly 66.0a1 (2018-12-18.