Closed Bug 1468688 Opened 5 years ago Closed 5 years ago

2.21 - 3.08% build times (linux64) regression on push 8a278eebbe5df459eab42bc7f1f515cbc8e38a01 (Sat Jun 9 2018)


(Firefox Build System :: General, defect)

Not set


(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox60 unaffected, firefox61 unaffected, firefox62 fixed)

Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 --- fixed


(Reporter: igoldan, Assigned: scarrillo)



(Keywords: regression)


(1 file)

We have detected a build metrics regression from push:

As author of one of the patches included in that push, we need your help to address this regression.


  3%  build times linux64 opt taskcluster-c4.4xlarge tup     1,100.16 -> 1,134.02
  2%  build times linux64 opt plain taskcluster-c4.4xlarge   2,057.16 -> 2,102.68

You can find links to graphs and comparison views for each of the above tests at:

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see:
Product: Testing → Firefox Build System
Version: 62 Branch → unspecified
Flags: needinfo?(scarrillo)
Bug 1464235 seems the one related to this regression. If I got this wrong, please let me know. Some how, the performance results don't show up per changeset, even though I backfilled them several times from Treeherder.
The tup build is expected to regress from bug 1464235 since zipping and uploading the tup database takes a decent amount of time. However, chmanchester mentioned that we should only be uploading that artifact on demand rather than on every push. :scarrillo will add a patch to fix that.

From the graph, the linux64 plain build looks like it was just a spurious incident and not a regression. Future builds were back down to the original range. I don't think bug 1464235 should've affected those builds anyway, since it's specific to the tup build.
Flags: needinfo?(scarrillo)
Attachment #8986029 - Flags: review?(mshal)
Comment on attachment 8986029 [details]
Bug 1468688 - default to upload tub db is false

Looks good - thanks!
Attachment #8986029 - Flags: review?(mshal) → review+
Assignee: nobody → scarrillo
Pushed by
default to upload tub db is false r=mshal
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.