1468690 - On github readme pages, caret navigation doesn't work with anchors

Status: VERIFIED INVALID

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Samuel Thibault]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180608092504

Steps to reproduce:

- Go to https://github.com/themix-project/oomox
- Enable caret navigation with f7
- Go to "Arch Linux, Manjaro" link inside the README.md box, which is a link to internal anchor: <a href="#centos-fedora-mageia">CentOS, Fedora, Mageia</a>
- Hit Enter
- Type right arrow


Actual results:

Caret is still inside the "Arch Linux, Manjaro" link.


Expected results:

Caret should have gone to the anchor.

Comment 1

[Samuel Thibault]

Oddly enough, this doesn't happend on e.g. anchor links on http://dept-info.labri.fr/~thibault/enseignements.html.fr , I don't know what would be special about the github page.

Comment 2

[Samuel Thibault]

FTR, I have just tried today's nightly (buildid 20180613220131, milestone 62.0a1), with the same result.

Comment 3

[Alex ARNAUD]

Hello all,

I can confirm this issue also on Windows 10 with Firefox 60.

@Jamie: Do you think it ss a bug inside the site or inside Firefox ? We don't see what is different between Github and others sites with anchors.


Best regards,
Alex.

Comment 4

[Abe - QA (:Abe_LV)]

This is reproducible on Windows 10 with the latest nightly build. Caret does not move to the anchor.

Test Env't
---------
Version 	62.0a1
Build ID 	20180619102337
Update Channel 	nightly
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0

Comment 5

[James Teh [:Jamie]]

(In reply to Samuel Thibault from comment #0)
> - Go to "Arch Linux, Manjaro" link inside the README.md box, which is a link
> to internal anchor: <a href="#centos-fedora-mageia">CentOS, Fedora,
> Mageia</a>

I assume the link and URL are mismatched here. I see https://github.com/themix-project/oomox#arch-linux. Nevertheless...

> Caret should have gone to the anchor.

That'd be nice, but due to GitHub weirdness (I assume a bug), the anchor for the heading is translated to "user-content-arch-linux", even though the link to the anchor isn't translated too:

<h3><a id="user-content-arch-linux" class="anchor" aria-hidden="true" href="#arch-linux"><svg ...>...</svg></a>Arch Linux:</h3>

The anchor "arch-linux" doesn't exist in the GitHub rendering of the readme, so there's nothing for Firefox to jump to.

Closing as invalid, since this isn't our bug.

Comment 6

[Samuel Thibault]

Sorry for the id mixup indeed.

Mmm, indeed there is some name mangling. But then I wonder how firefox does scroll to the anchor?  I guess that if firefox hadn't been scrolling, github people would have fixed their bug. It is the kind of behavior difference between screen rendering and accessibility semantic, which makes some bugs exposed only to people needing the accessibility features, and thus not fixed.

Comment 7

[Alex ARNAUD]

(In reply to Samuel Thibault from comment #6)
> Sorry for the id mixup indeed.
> 
> Mmm, indeed there is some name mangling. But then I wonder how firefox does
> scroll to the anchor?  I guess that if firefox hadn't been scrolling, github
> people would have fixed their bug. It is the kind of behavior difference
> between screen rendering and accessibility semantic, which makes some bugs
> exposed only to people needing the accessibility features, and thus not
> fixed.

After looking more deeply it seems it's a JavaScript managed stuff on the Github side, see https://github.com/github/markup/issues/425

It look likes we've to report it to them.

Best regards,
Alex.

Comment 8

[Samuel Thibault]

Ok, thanks for digging! We'll see with github then.