1468717 - Submitting done and adding a reply leaves UI in bad state

Status: NEW

(Conduit :: Phabricator, defect, P5)

Description

[Mark Banner (:standard8)]

Attachment: Screen Shot 2018-06-14 at 13.03.11.png

STR:

1) Submit a patch.
2) Get review feedback with a comment asking for a change.
3) Do the changes
4) Run `arc diff` to update the patch.
5) Go back and try to mark the comment as done & reply to it.

=> The UX here is really confusing, the reviewer's comment looks like it is greyed out, but still allows you to check the box. This is possibly another bug.

6) Tick the box for done on the reviewer's comment.

=> The UI shows unsubmitted for their comment, and checks the done box.

7) Click the reply button and enter a reply, save as draft.
8) Go down the bottom and click the Submit button.

Expected Results.

The comments are marked as done, and submitted.

Actual Results.

-> The reviewer's comment still shows unsubmitted.
-> My reply shows submitted.
-> The history shows that a comment was marked as done (though doesn't say which one).
-> The history shows my comment.
-> Scrolling down, the UI also still shows there's one unsubmitted comment.

See the attachment for what the UI looked like.

Comment 1

[Mark Banner (:standard8)]

Submitting for a second time cleared the reviewer's submit comment.