1468821 - Remove .menu-iconic-right selectors from menu.css

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P3)

Description

[Dão Gottwald [:dao]]

The menu-iconic-right class isn't used anymore, so we should remove it from selectors:

https://searchfox.org/mozilla-central/search?q=menu-iconic-right&case=true&path=

Comment 1

[Israel Madueme [:imadueme]]

Mind if I work on this bug? I'm trying to get some experience writing and testing for Firefox?

Comment 2

[Dão Gottwald [:dao]]

Not at all, go ahead!

Comment 3

[Dão Gottwald [:dao]]

Are you still going to work on this?

Comment 4

[Israel Madueme [:imadueme]]

@Dao If it's time critical, you can unassign me and have someone else pick it up :)

I recently managed to get FF to build following the instructions at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites. I'll probably have to figure out how to get artifact builds working to speed things up.

Also, while the fix is simple, I was wondering if you have an idea on how to test the change. I'm not sure what could break by removing that selector or if pushing to try would catch that sort of thing. Any instructions there would be appreciated, or if you already are sure it's just the 1 line fix I'll push up a patch. Thanks!

Comment 5

[Dão Gottwald [:dao]]

I don't think there's much to test here, code search shows that this class is unused.

Comment 6

[Israel Madueme [:imadueme]]

Attachment: Bug 1468821 - Remove .menu-iconic-right selectors from menu.css.

The .menu-iconic-right class is not used anymore so it can be removed.

Review commit: https://reviewboard.mozilla.org/r/253886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253886/

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8988654 [details]
Bug 1468821 - Remove .menu-iconic-right selectors from menu.css.

https://reviewboard.mozilla.org/r/253886/#review260626

Thanks!

Comment 8

[Israel Madueme [:imadueme]]

As I don't have L3, what would be the next step to get this landed? Should I set checkin-needed on this bug, or are you able to land that change? Thanks :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f3ec97c6236
Remove .menu-iconic-right selectors from menu.css. r=dao

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2f3ec97c6236