Closed Bug 1468821 Opened 2 years ago Closed 2 years ago

Remove .menu-iconic-right selectors from menu.css

Categories

(Toolkit :: Themes, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: dao, Assigned: imadueme, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file)

The menu-iconic-right class isn't used anymore, so we should remove it from selectors:

https://searchfox.org/mozilla-central/search?q=menu-iconic-right&case=true&path=
Mind if I work on this bug? I'm trying to get some experience writing and testing for Firefox?
Flags: needinfo?(dao+bmo)
Not at all, go ahead!
Assignee: nobody → imadueme
Flags: needinfo?(dao+bmo)
Are you still going to work on this?
Flags: needinfo?(imadueme)
@Dao If it's time critical, you can unassign me and have someone else pick it up :)

I recently managed to get FF to build following the instructions at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites. I'll probably have to figure out how to get artifact builds working to speed things up.

Also, while the fix is simple, I was wondering if you have an idea on how to test the change. I'm not sure what could break by removing that selector or if pushing to try would catch that sort of thing. Any instructions there would be appreciated, or if you already are sure it's just the 1 line fix I'll push up a patch. Thanks!
Flags: needinfo?(dao+bmo)
Flags: needinfo?(imadueme)
I don't think there's much to test here, code search shows that this class is unused.
Flags: needinfo?(dao+bmo)
Comment on attachment 8988654 [details]
Bug 1468821 - Remove .menu-iconic-right selectors from menu.css.

https://reviewboard.mozilla.org/r/253886/#review260626

Thanks!
Attachment #8988654 - Flags: review?(dao+bmo) → review+
As I don't have L3, what would be the next step to get this landed? Should I set checkin-needed on this bug, or are you able to land that change? Thanks :)
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f3ec97c6236
Remove .menu-iconic-right selectors from menu.css. r=dao
Flags: needinfo?(dao+bmo)
https://hg.mozilla.org/mozilla-central/rev/2f3ec97c6236
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.