Remove .menu-iconic-right selectors from menu.css

RESOLVED FIXED in Firefox 63

Status

()

P3
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: dao, Assigned: imadueme, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla63
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [lang=css])

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
The menu-iconic-right class isn't used anymore, so we should remove it from selectors:

https://searchfox.org/mozilla-central/search?q=menu-iconic-right&case=true&path=
(Assignee)

Comment 1

8 months ago
Mind if I work on this bug? I'm trying to get some experience writing and testing for Firefox?
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 2

8 months ago
Not at all, go ahead!
Assignee: nobody → imadueme
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 3

8 months ago
Are you still going to work on this?
Flags: needinfo?(imadueme)
(Assignee)

Comment 4

8 months ago
@Dao If it's time critical, you can unassign me and have someone else pick it up :)

I recently managed to get FF to build following the instructions at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites. I'll probably have to figure out how to get artifact builds working to speed things up.

Also, while the fix is simple, I was wondering if you have an idea on how to test the change. I'm not sure what could break by removing that selector or if pushing to try would catch that sort of thing. Any instructions there would be appreciated, or if you already are sure it's just the 1 line fix I'll push up a patch. Thanks!
Flags: needinfo?(dao+bmo)
(Assignee)

Updated

8 months ago
Flags: needinfo?(imadueme)
(Reporter)

Comment 5

8 months ago
I don't think there's much to test here, code search shows that this class is unused.
Flags: needinfo?(dao+bmo)
Comment hidden (mozreview-request)
(Reporter)

Comment 7

8 months ago
mozreview-review
Comment on attachment 8988654 [details]
Bug 1468821 - Remove .menu-iconic-right selectors from menu.css.

https://reviewboard.mozilla.org/r/253886/#review260626

Thanks!
Attachment #8988654 - Flags: review?(dao+bmo) → review+
(Assignee)

Comment 8

8 months ago
As I don't have L3, what would be the next step to get this landed? Should I set checkin-needed on this bug, or are you able to land that change? Thanks :)
Flags: needinfo?(dao+bmo)

Comment 9

8 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f3ec97c6236
Remove .menu-iconic-right selectors from menu.css. r=dao
(Reporter)

Updated

8 months ago
Flags: needinfo?(dao+bmo)

Comment 10

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2f3ec97c6236
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.