Closed Bug 1468911 Opened 6 years ago Closed 5 years ago

[Wayland] Visible artifacts during window resize

Categories

(Core :: Widget: Gtk, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox62 --- wontfix
firefox68 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When main window is resized there are visible artifacts - damaged screen and so on.
Assignee: nobody → stransky
See Also: → 1535565
Depends on: 1536099

When wayland surface is newly created or resized,
postpone buffer commit (drawing) until gecko updates whole screen
and don't publish partial updates.

Just tested the latest firefox 66 build from koji for fedora 29 which contains a fix for this issue. I then grabbed the bottom right corner of firefox and just did circular motions with the mouse to test the resizing. The result was that the window refresh stopped after just half a second or so, and I ended upp with just a dropshadow rectangle (I guess drawn by mutter) being resized and following my mouse. And when I stopped the resize the window was still not refreshed, so I had my strange looking window and a drop-shadow rectangle.

Then To reset things, I just did a maximize window and back.

I see, thanks for testing.

(In reply to Mattias from comment #2)

Just tested the latest firefox 66 build from koji for fedora 29 which
contains a fix for this issue. I then grabbed the bottom right corner of
firefox and just did circular motions with the mouse to test the resizing.
The result was that the window refresh stopped after just half a second or
so, and I ended upp with just a dropshadow rectangle (I guess drawn by
mutter) being resized and following my mouse. And when I stopped the resize
the window was still not refreshed, so I had my strange looking window and a
drop-shadow rectangle.

Then To reset things, I just did a maximize window and back.

That should be covered by a new patch attached here.

Tested it and I cannot reproduce the issues I had with the previous patch. So it works from that perspective... I don't see any other visual artifacts during resize either.

For me this patch fixes the damage when manually resizing the window but not when restoring/maximizing/fullscreening on Ubuntu 18.10 with Mesa 19.1-devel.

(In reply to Kestrel from comment #6)

For me this patch fixes the damage when manually resizing the window but not
when restoring/maximizing/fullscreening on Ubuntu 18.10 with Mesa 19.1-devel.

Those artifacts comes from Gtk and need a different fix.

(In reply to Martin Stránský [:stransky] from comment #7)

Those artifacts comes from Gtk and need a different fix.

In which case Bug 1535565 is unrelated.

See Also: 1535565

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85721a77dd52
[Wayland] Visible artifacts during window resize, r=ashie

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: