1468992 - Remove the Library infopane More/Less toggle

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[Marco Bonardo [:mak]]

The only thing it will be hiding is the keyword field that pretty much takes the same space, so no reason to keep it.
This should simplify some of the editBookmark code.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1468992 - Remove the Library infopane More/Less toggle.

Review commit: https://reviewboard.mozilla.org/r/253902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253902/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8988695 [details]
Bug 1468992 - Remove the Library infopane More/Less toggle.

https://reviewboard.mozilla.org/r/253902/#review260730

::: browser/components/places/content/places.js
(Diff revision 1)
> -
> -    if (infoBox.getAttribute("minimal") == "true") {
> -      infoBox.removeAttribute("minimal");
> -      infoBoxExpanderLabel.value = infoBoxExpanderLabel.getAttribute("lesslabel");
> -      infoBoxExpanderLabel.accessKey = infoBoxExpanderLabel.getAttribute("lessaccesskey");
> -      infoBoxExpander.className = "expander-up";

I think you can remove the styles for expander-up and expander-down classes from
browser/themes/osx/places/organizer.css
The expanders there should already pick their style from editBookmark.css, IIRC

::: browser/components/places/content/places.xul:444
(Diff revision 1)
>            <description id="selectItemDescription">
>                &detailsPane.selectAnItemText.description;
>            </description>
>            <spacer flex="3"/>
>          </vbox>
>          <vbox id="infoBox" minimal="true">

the minimal attribute can go away from here, isn't it?

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8988695 [details]
Bug 1468992 - Remove the Library infopane More/Less toggle.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253902/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90ac310bc9af
Remove the Library infopane More/Less toggle. r=mak

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/90ac310bc9af