Remove the Library infopane More/Less toggle

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P3
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: mak, Assigned: dao)

Tracking

(Blocks 1 bug)

unspecified
Firefox 63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Reporter

Description

Last year
The only thing it will be hiding is the keyword field that pretty much takes the same space, so no reason to keep it.
This should simplify some of the editBookmark code.
Reporter

Updated

Last year
Blocks: 1471546
Assignee

Updated

Last year
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Reporter

Comment 2

Last year
mozreview-review
Comment on attachment 8988695 [details]
Bug 1468992 - Remove the Library infopane More/Less toggle.

https://reviewboard.mozilla.org/r/253902/#review260730

::: browser/components/places/content/places.js
(Diff revision 1)
> -
> -    if (infoBox.getAttribute("minimal") == "true") {
> -      infoBox.removeAttribute("minimal");
> -      infoBoxExpanderLabel.value = infoBoxExpanderLabel.getAttribute("lesslabel");
> -      infoBoxExpanderLabel.accessKey = infoBoxExpanderLabel.getAttribute("lessaccesskey");
> -      infoBoxExpander.className = "expander-up";

I think you can remove the styles for expander-up and expander-down classes from
browser/themes/osx/places/organizer.css
The expanders there should already pick their style from editBookmark.css, IIRC

::: browser/components/places/content/places.xul:444
(Diff revision 1)
>            <description id="selectItemDescription">
>                &detailsPane.selectAnItemText.description;
>            </description>
>            <spacer flex="3"/>
>          </vbox>
>          <vbox id="infoBox" minimal="true">

the minimal attribute can go away from here, isn't it?
Attachment #8988695 - Flags: review?(mak77) → review+
Comment hidden (mozreview-request)

Comment 4

Last year
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90ac310bc9af
Remove the Library infopane More/Less toggle. r=mak

Comment 5

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/90ac310bc9af
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.