1469004 - Provide an API to create a module namespace object for a module

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jon Coppeard (:jonco)]

As requested by Ted for JSM/ES6 modules integration.  This is also necessary for implementing dynamic import.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1469004-create-namespace

Patch to add ModuleObject::GetOrCreateModuleNamespace().

Comment 2

[Jon Coppeard (:jonco)]

Attachment: bug1469004-create-namespace v2

Rebased patch.  This isn't used at the moment but is required by future patches.

Comment 3

[André Bargull [:anba]]

Comment on attachment 8998912 [details] [diff] [review]
bug1469004-create-namespace v2

Review of attachment 8998912 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

::: js/src/builtin/ModuleObject.cpp
@@ +1157,5 @@
> +    FixedInvokeArgs<1> args(cx);
> +    args[0].setObject(*self);
> +
> +    RootedValue result(cx);
> +    if (!CallSelfHostedFunction(cx, cx->names().GetModuleNamespace, thisv, args, &result))

Instead of the otherwise unused |thisv|, you can use |UndefinedHandleValue| for the this-argument.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8289b70dc0db
Add an API to create a module namespace object r=anba

Comment 5

[Natalia Csoregi [:nataliaCs]]

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1482153#c6

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/08bf805f6f0e
Add an API to create a module namespace object r=anba

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/08bf805f6f0e