Closed
Bug 1469028
Opened 6 years ago
Closed 6 years ago
Too many "Renderer" threads
Categories
(Core :: Graphics: WebRender, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: kats, Assigned: sotaro)
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
|
1.32 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
If you take a gecko profile of all threads with WR enabled on windows, there are 4 "Renderer" threads. Two of these are created at [1] and two are created at [2]. Within each pair, one is from the GPU process and one is from the main process. If the GPU process is enabled, it seems like we shouldn't need to create the main process pair. So we should stop doing that. It gets created from InitLayersIPC(). Also it would be good to rename the WinCompositorWindowThread threads so that they're called "WinCompositor" or something different than Renderer so that it's less confusing as to what they are. [1] https://searchfox.org/mozilla-central/rev/42930ab9634ebf3f62aed60f7d1c1bf25c0bf00c/gfx/webrender_bindings/RenderThread.cpp#60 [2] https://searchfox.org/mozilla-central/rev/42930ab9634ebf3f62aed60f7d1c1bf25c0bf00c/widget/windows/WinCompositorWindowThread.cpp#40
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4425116f3f7ee39702d57cbbfa800ce79dac09fb
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8986372 -
Flags: review?(nical.bugzilla)
|
||
Updated•6 years ago
|
Attachment #8986372 -
Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a96803397f18 Supress Renderer threads r=nical
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a96803397f18
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•