Closed Bug 1469067 Opened 2 years ago Closed 2 years ago

Build host programs in their final location

Categories

(Firefox Build System :: General, enhancement)

3 Branch
enhancement
Not set

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The "brotli" host program creates a weird interaction with Tup when using clang. We can work around this by just building it in its final location.
Assignee: nobody → cmanchester
FWIW, I looked into why we build this at all and it was turned on in a bug blocking bug 1352595, so presumably glandium intended to use brotli for omni.ja compression at some point.
Comment on attachment 8986060 [details]
Bug 1469067 - Build host programs in their final locations rather than copying them to dist/host/bin.

https://reviewboard.mozilla.org/r/251510/#review257996

Looks great to me. The only thing I wasn't able to double-check is the MS_MANIFEST stuff, but the rest works well in both the make and tup backends as far as I can tell.
Attachment #8986060 - Flags: review+
Attachment #8986060 - Flags: review?(core-build-config-reviews)
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33c34fbb0b0d
Build host programs in their final locations rather than copying them to dist/host/bin. r=mshal
https://hg.mozilla.org/mozilla-central/rev/33c34fbb0b0d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.