Closed
Bug 1469095
Opened 4 years ago
Closed 4 years ago
diffoscope tasks are busted when using index-search
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
[task 2018-06-16T00:46:29.280Z] Exception: In job.run using u'always-optimized'/u'always-optimized' for job u'index-search-gecko.v2.autoland.revision.f7e0c30a33bc696cfed8ba8be592e2d971bc1cc8.firefox.macosx64-opt': [task 2018-06-16T00:46:29.280Z] extra keys not allowed @ data[u'workdir'] [task 2018-06-16T00:46:29.280Z] {u'using': u'always-optimized', u'workdir': u'/builds/worker'}
Comment hidden (mozreview-request) |
Comment 2•4 years ago
|
||
mozreview-review |
Comment on attachment 8985742 [details] Bug 1469095 - Fix always-optimized jobs after bug 1465181. https://reviewboard.mozilla.org/r/251272/#review257738 Can you add some explanation of this? It looks simple enough, but I don't see what it accomplishes..
Comment 4•4 years ago
|
||
Not really -- it seems like the better fix would be to not pass it a parameter it doesn't use, rather than to include that parameter in the schema.
Flags: needinfo?(dustin)
Comment hidden (mozreview-request) |
Comment 6•4 years ago
|
||
mozreview-review |
Comment on attachment 8985742 [details] Bug 1469095 - Fix always-optimized jobs after bug 1465181. https://reviewboard.mozilla.org/r/251272/#review258226 ::: taskcluster/taskgraph/transforms/job/__init__.py:155 (Diff revision 2) > assert 'implementation' not in worker > worker['implementation'] = impl > if os: > worker['os'] = os > > + if job['run']['using'] != 'always-optimized': # always-optimized tasks never execute, so have no workDir
Attachment #8985742 -
Flags: review?(dustin) → review+
Comment hidden (mozreview-request) |
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/88a05771dd2b Fix always-optimized jobs after bug 1465181. r=dustin
Comment 9•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/88a05771dd2b
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Updated•3 years ago
|
Version: Version 3 → 3 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•