Closed Bug 1469095 Opened 4 years ago Closed 4 years ago

diffoscope tasks are busted when using index-search

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Version:
3 Branch
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Bug 1469095 - Fix always-optimized jobs after bug 1465181.
59 bytes, text/x-review-board-request
dustin
: review+
Details 
[task 2018-06-16T00:46:29.280Z] Exception: In job.run using u'always-optimized'/u'always-optimized' for job u'index-search-gecko.v2.autoland.revision.f7e0c30a33bc696cfed8ba8be592e2d971bc1cc8.firefox.macosx64-opt':
[task 2018-06-16T00:46:29.280Z] extra keys not allowed @ data[u'workdir']
[task 2018-06-16T00:46:29.280Z] {u'using': u'always-optimized', u'workdir': u'/builds/worker'}
Comment on attachment 8985742 [details]
Bug 1469095 - Fix always-optimized jobs after bug 1465181.

https://reviewboard.mozilla.org/r/251272/#review257738

Can you add some explanation of this?  It looks simple enough, but I don't see what it accomplishes..
Isn't comment 0 enough context?
Flags: needinfo?(dustin)
Not really -- it seems like the better fix would be to not pass it a parameter it doesn't use, rather than to include that parameter in the schema.
Flags: needinfo?(dustin)
Comment on attachment 8985742 [details]
Bug 1469095 - Fix always-optimized jobs after bug 1465181.

https://reviewboard.mozilla.org/r/251272/#review258226

::: taskcluster/taskgraph/transforms/job/__init__.py:155
(Diff revision 2)
>          assert 'implementation' not in worker
>          worker['implementation'] = impl
>          if os:
>              worker['os'] = os
>  
> +        if job['run']['using'] != 'always-optimized':

# always-optimized tasks never execute, so have no workDir
Attachment #8985742 - Flags: review?(dustin) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/88a05771dd2b
Fix always-optimized jobs after bug 1465181. r=dustin
https://hg.mozilla.org/mozilla-central/rev/88a05771dd2b
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.