1469095 - diffoscope tasks are busted when using index-search

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Mike Hommey [:glandium]]

[task 2018-06-16T00:46:29.280Z] Exception: In job.run using u'always-optimized'/u'always-optimized' for job u'index-search-gecko.v2.autoland.revision.f7e0c30a33bc696cfed8ba8be592e2d971bc1cc8.firefox.macosx64-opt':
[task 2018-06-16T00:46:29.280Z] extra keys not allowed @ data[u'workdir']
[task 2018-06-16T00:46:29.280Z] {u'using': u'always-optimized', u'workdir': u'/builds/worker'}

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1469095 - Fix always-optimized jobs after bug 1465181.

Review commit: https://reviewboard.mozilla.org/r/251272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251272/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8985742 [details]
Bug 1469095 - Fix always-optimized jobs after bug 1465181.

https://reviewboard.mozilla.org/r/251272/#review257738

Can you add some explanation of this?  It looks simple enough, but I don't see what it accomplishes..

Comment 3

[Mike Hommey [:glandium]]

Isn't comment 0 enough context?

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Not really -- it seems like the better fix would be to not pass it a parameter it doesn't use, rather than to include that parameter in the schema.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8985742 [details]
Bug 1469095 - Fix always-optimized jobs after bug 1465181.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251272/diff/1-2/

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8985742 [details]
Bug 1469095 - Fix always-optimized jobs after bug 1465181.

https://reviewboard.mozilla.org/r/251272/#review258226

::: taskcluster/taskgraph/transforms/job/__init__.py:155
(Diff revision 2)
>          assert 'implementation' not in worker
>          worker['implementation'] = impl
>          if os:
>              worker['os'] = os
>  
> +        if job['run']['using'] != 'always-optimized':

# always-optimized tasks never execute, so have no workDir

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8985742 [details]
Bug 1469095 - Fix always-optimized jobs after bug 1465181.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251272/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88a05771dd2b
Fix always-optimized jobs after bug 1465181. r=dustin

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/88a05771dd2b