1469108 - Propagate directionality from the shadow host to the shadow root.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

But don't make shadow root content affect directionality of the host or ancestors if they have dir="auto", since that would be observable even when the shadow root is closed.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1469108: Fix some pre-existing style issues / unnecessary default arguments.

Review commit: https://reviewboard.mozilla.org/r/251280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251280/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1469108: Propagate directionality to the shadow tree.

Make it so that directionality of the ShadowRoot descendants is computed based
on the host and it's ancestors, but don't touch the dir=auto code, since I don't
think anybody agrees with what needs to happen there, and I think in general
it shouldn't be accounted for.

Review commit: https://reviewboard.mozilla.org/r/251282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251282/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8985748 [details]
Bug 1469108: Fix some pre-existing style issues / unnecessary default arguments.

https://reviewboard.mozilla.org/r/251280/#review257644

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8985749 [details]
Bug 1469108: Propagate directionality to the shadow tree.

https://reviewboard.mozilla.org/r/251282/#review257712

Could you add a test where an element which has shadow DOM attached, is appended to another element which has dir=rtl. rtl state should be inherited to shadow DOM.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe329c5d7e39
Fix some pre-existing style issues / unnecessary default arguments. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/0398e981e6a0
Propagate directionality to the shadow tree. r=smaug

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/fe329c5d7e39
https://hg.mozilla.org/mozilla-central/rev/0398e981e6a0

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11565 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged