1469239 - disable hg ftl (l10n) check hook during merge day, Monday June 18th for mozilla-beta mozilla-release mozilla-esr60 repos

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

Hi folks, 
It's merge day again, could we get these hooks disabled for mozilla-beta, mozilla-release and mozilla-esr60? Thanks!

+++ This bug was initially created as a clone of Bug #1441782 +++

Assuming this check is still enabled, we will need to disable it during Merge day.

Ideally this should be disabled at around 0000 pt Feb 1st for both mozilla-beta and mozilla-release repos until releng give the all clear (later that day).

For context, there was an issue disabling this last time:
#vcs
[2018-01-11 16:24:28] <Callek> fubar: I hit a hook failure on merge day, can we temporarily disable it from moz-release (will need to disable from beta for sometime today too)
[2018-01-11 16:44:33] <fubar> Callek: try now
[2018-01-11 17:01:13] <Callek> fubar: still failed
[2018-01-11 17:02:02] <fubar> -.-
[2018-01-11 17:02:04] <fubar> same error?
[2018-01-11 17:02:35] <Callek> yea
[2018-01-11 17:03:04] <Callek> log:      https://irccloud.mozilla.com/pastebin/OOJb8NbI/
[2018-01-11 17:06:36] <fubar> I'm really not sure why; I added `check.prevent_ftl_changes = false` to hgrc
[2018-01-11 17:09:55] <Callek> for mozilla-release?
[2018-01-11 17:12:04] <fubar> even looking at the blackbox log, I don't see any mention of the ftl check firing, but maybe it's wrapped up in hgext_mozhooks.pretxnchangegroup
[2018-01-11 17:26:56] <gps> i'm around now
[2018-01-11 17:29:15] <gps> Callek: updated the hgrc on mozilla-release
[2018-01-11 17:29:57] <Callek> thanks
[2018-01-11 17:30:06] — Callek runs again :-)
[2018-01-11 17:45:27] — fubar silently rages that the (file)name of the hook and what's returned by name() is utterly inconsistent
[2018-01-11 17:48:58] <gps> uh huh
[2018-01-11 17:55:35] <Callek> gps: confirmed, the disable worked, and now mozilla-release is 58.0

Comment 1

[Kendall Libby [:fubar] (he/him)]

'check.ftl_check = false' was already set on esr60; added it to beta and release.

Comment 2

[Jordan Lund (:jlund)]

we can now revert this and re-enable hooks, including whatever work connor did for pretxnclose.vcsreplicator

Comment 3

[Connor Sheehan [:sheehan]]

Removed `mozilla.check.ftl_check=false` from the hgrc for mozilla-beta and mozilla-release. vcsreplicator is turned on as well, it looks like gps did that yesterday.