1469276 - Remove some unnecessary nsAttrAndChildArray usage.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1469276: Remove some unnecessary nsAttrAndChildArray usage.

I couldn't make any sense about the BindToTree comment, so I removed it.

There's no DestroyContent implementation that fiddles with child lists, so this
should be fine.

Review commit: https://reviewboard.mozilla.org/r/251402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251402/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8985917 [details]
Bug 1469276: Remove some unnecessary nsAttrAndChildArray usage.

https://reviewboard.mozilla.org/r/251402/#review257682

::: commit-message-9b6f2:5
(Diff revision 1)
> +Bug 1469276: Remove some unnecessary nsAttrAndChildArray usage. r?smaug
> +
> +I couldn't make any sense about the BindToTree comment, so I removed it.
> +
> +There's no DestroyContent implementation that fiddles with child lists, so this

Really? https://searchfox.org/mozilla-central/rev/285da1fd7dcf67448b9175741fa330158edcff73/dom/base/FragmentOrElement.cpp#1289-1290
Or am I missing something?


The old code is of course also wrong, since if node is removed, indexing doesn't work correctly.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8985917 [details]
Bug 1469276: Remove some unnecessary nsAttrAndChildArray usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251402/diff/1-2/

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8985917 [details]
Bug 1469276: Remove some unnecessary nsAttrAndChildArray usage.

Err, missed the previous comment, will update.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8985917 [details]
Bug 1469276: Remove some unnecessary nsAttrAndChildArray usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251402/diff/2-3/

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8985917 [details]
Bug 1469276: Remove some unnecessary nsAttrAndChildArray usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251402/diff/3-4/

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8985917 [details]
Bug 1469276: Remove some unnecessary nsAttrAndChildArray usage.

https://reviewboard.mozilla.org/r/251402/#review257694

Better to push to try (debug builds) to see if something breaks :)

::: commit-message-9b6f2:5
(Diff revision 4)
> +Bug 1469276: Remove some unnecessary nsAttrAndChildArray usage. r?smaug
> +
> +I couldn't make any sense about the BindToTree comment, so I removed it.
> +
> +There's no DestroyContent implementation that fiddles with child lists, so this

This sentence isn't quite right, since JS could in theory do anything. But we control all that

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8985917 [details]
Bug 1469276: Remove some unnecessary nsAttrAndChildArray usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251402/diff/4-5/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9ead3b8d077
Remove some unnecessary nsAttrAndChildArray usage. r=smaug

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a9ead3b8d077