Closed
Bug 1469290
Opened 7 years ago
Closed 7 years ago
Avoid extra locks in NS_ReadInputStreamToBuffer
Categories
(Core :: Networking, enhancement)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file, 1 obsolete file)
|
9.03 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
I just went through the code of NS_ReadInputStreamToBuffer and I think we can avoid the locking completely. It's fine exec ReadSegments() on the owning thread for nsIAsyncInputStream if there is available data.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8985925 -
Flags: review?(valentin.gosu)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8985925 [details] [diff] [review]
stream2.patch
Review of attachment 8985925 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not familiar with this class but at least, when you are removing locks in a class that doesn't enforce single-thread usage by any other means, please add assertions for single thread usage.
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8985925 -
Attachment is obsolete: true
Attachment #8985925 -
Flags: review?(valentin.gosu)
Attachment #8985951 -
Flags: review?(valentin.gosu)
|
||
Updated•7 years ago
|
Attachment #8985951 -
Flags: review?(valentin.gosu) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f194f3fb2e6e
Avoid extra locks in NS_ReadInputStreamToBuffer, r=valentin
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•