theme.getCurrent() should not require `theme` permission

RESOLVED FIXED in Firefox 62

Status

defect
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: ntim, Assigned: ntim)

Tracking

(Blocks 1 bug)

unspecified
mozilla62
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox62 fixed)

Details

(Whiteboard: [ntim-intern-project])

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

11 months ago
Extensions with the `theme` permission will be categorized as themes rather than extensions, so using `theme.getCurrent()` should not require this categorization.
Assignee

Updated

11 months ago
Assignee: nobody → ntim.bugs
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

11 months ago
Attachment #8985960 - Attachment is obsolete: true
Attachment #8985960 - Flags: review?(jaws)
Comment on attachment 8985962 [details]
Bug 1469318 - Do not require 'theme' permission for theme.getCurrent() and theme.onUpdated.

https://reviewboard.mozilla.org/r/251436/#review257718
Attachment #8985962 - Flags: review?(jaws) → review+

Comment 4

11 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c40cef0e222
Do not require 'theme' permission for theme.getCurrent() and theme.onUpdated. r=jaws
Backed out changeset 1c40cef0e222 (bug 1469318) for mochitest failures on test_ext_all_apis.html 

Backout: https://hg.mozilla.org/integration/autoland/rev/c2ced94f52aade1532494cfdd31d6fdacd3f1edf

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1c40cef0e22283838e3ec74b52c19cd2e9da2a70&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&selectedJob=183636133

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=183636133&repo=autoland&lineNumber=2072

[task 2018-06-18T18:01:14.550Z] 18:01:14     INFO -  683 INFO TEST-START | mobile/android/components/extensions/test/mochitest/test_ext_all_apis.html
[task 2018-06-18T18:01:35.309Z] 18:01:35     INFO -  Buffered messages logged at 18:01:09
[task 2018-06-18T18:01:35.309Z] 18:01:35     INFO -  684 INFO AddTask.js | Entering test test_enumerate_content_script_apis
[task 2018-06-18T18:01:35.313Z] 18:01:35     INFO -  685 INFO Extension loaded
[task 2018-06-18T18:01:35.313Z] 18:01:35     INFO -  Buffered messages logged at 18:01:22
[task 2018-06-18T18:01:35.314Z] 18:01:35     INFO -  686 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_all_apis.html | content script APIs
[task 2018-06-18T18:01:35.315Z] 18:01:35     INFO -  Buffered messages logged at 18:01:25
[task 2018-06-18T18:01:35.315Z] 18:01:35     INFO -  687 INFO AddTask.js | Leaving test test_enumerate_content_script_apis
[task 2018-06-18T18:01:35.315Z] 18:01:35     INFO -  688 INFO AddTask.js | Entering test test_enumerate_background_script_apis
[task 2018-06-18T18:01:35.315Z] 18:01:35     INFO -  689 INFO Extension loaded
[task 2018-06-18T18:01:35.315Z] 18:01:35     INFO -  Buffered messages finished
[task 2018-06-18T18:01:35.315Z] 18:01:35     INFO -  690 INFO TEST-UNEXPECTED-FAIL | mobile/android/components/extensions/test/mochitest/test_ext_all_apis.html | background script APIs -     Structures begin differing at:
[task 2018-06-18T18:01:35.315Z] 18:01:35     INFO -  got[91] = "browser.theme.getCurrent"
[task 2018-06-18T18:01:35.315Z] 18:01:35     INFO -  expected[91] = "browser.types.LevelOfControl"
[task 2018-06-18T18:01:35.315Z] 18:01:35     INFO -      SimpleTest.isDeeply@SimpleTest/SimpleTest.js:1602:9
[task 2018-06-18T18:01:35.315Z] 18:01:35     INFO -      test_enumerate_background_script_apis@mobile/android/components/extensions/test/mochitest/test_ext_all_apis.js:169:3
[task 2018-06-18T18:01:35.316Z] 18:01:35     INFO -  691 INFO AddTask.js | Leaving test test_enumerate_background_script_apis
Flags: needinfo?(ntim.bugs)
Assignee

Updated

11 months ago
Attachment #8985962 - Attachment is obsolete: true
Comment on attachment 8986036 [details]
Bug 1469318 - Do not require 'theme' permission for theme.getCurrent() and theme.onUpdated.

https://reviewboard.mozilla.org/r/251490/#review257778
Attachment #8986036 - Flags: review?(jaws) → review+
Assignee

Updated

11 months ago
Flags: needinfo?(ntim.bugs)

Comment 8

11 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d923eb14e557
Do not require 'theme' permission for theme.getCurrent() and theme.onUpdated. r=jaws

Comment 9

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d923eb14e557
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62

Updated

11 months ago
Product: Toolkit → WebExtensions

Updated

11 months ago
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.