1469329 - Crash in mozilla::EventTargetChainItem::RetargetTouchTargets

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-fa7ef004-e9fc-49c9-94fb-e26640180602.
=============================================================

Seen while looking at Mac nightly crash stats. Crashes seem to go back to Build 20180526223142: https://bit.ly/2JZWTHA

Bug 1429572 landed in that timeframe. ni on :smaug

Top 10 frames of crashing thread:

0 XUL mozilla::EventTargetChainItem::RetargetTouchTargets mfbt/Maybe.h:549
1 XUL mozilla::EventTargetChainItem::HandleEventTargetChain dom/events/EventDispatcher.cpp:615
2 XUL mozilla::EventDispatcher::Dispatch dom/events/EventDispatcher.cpp:1086
3 XUL mozilla::EventDispatcher::DispatchDOMEvent dom/events/EventDispatcher.cpp
4 XUL nsINode::DispatchEvent dom/base/nsINode.cpp:1091
5 XUL mozilla::dom::EventTargetBinding::dispatchEvent dom/bindings/EventTargetBinding.cpp:987
6 XUL bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::MaybeGlobalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3283
7  @0x246b565f23df 
8  @0x188f73b9f 
9  @0x246b565f1800 

=============================================================

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: RetargetTouchTargets_crash.diff

HasRetargetTouchTargets() checks 
mRetargetedTouchTargets.isSome() || mInitialTargetTouches.isSome()

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: RetargetTouchTargets_crash.diff

A bit nicer place for the 'if'

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cde573c283a
ensure mRetargetedTouchTargets has touch objects before using it, r=masayuki

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4cde573c283a