Closed
Bug 1469329
Opened 6 years ago
Closed 6 years ago
Crash in mozilla::EventTargetChainItem::RetargetTouchTargets
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox-esr60 | --- | unaffected |
| firefox60 | --- | unaffected |
| firefox61 | --- | unaffected |
| firefox62 | --- | fixed |
People
(Reporter: marcia, Assigned: smaug)
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file, 1 obsolete file)
|
1.39 KB,
patch
|
masayuki
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-fa7ef004-e9fc-49c9-94fb-e26640180602. ============================================================= Seen while looking at Mac nightly crash stats. Crashes seem to go back to Build 20180526223142: https://bit.ly/2JZWTHA Bug 1429572 landed in that timeframe. ni on :smaug Top 10 frames of crashing thread: 0 XUL mozilla::EventTargetChainItem::RetargetTouchTargets mfbt/Maybe.h:549 1 XUL mozilla::EventTargetChainItem::HandleEventTargetChain dom/events/EventDispatcher.cpp:615 2 XUL mozilla::EventDispatcher::Dispatch dom/events/EventDispatcher.cpp:1086 3 XUL mozilla::EventDispatcher::DispatchDOMEvent dom/events/EventDispatcher.cpp 4 XUL nsINode::DispatchEvent dom/base/nsINode.cpp:1091 5 XUL mozilla::dom::EventTargetBinding::dispatchEvent dom/bindings/EventTargetBinding.cpp:987 6 XUL bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::MaybeGlobalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3283 7 @0x246b565f23df 8 @0x188f73b9f 9 @0x246b565f1800 =============================================================
Flags: needinfo?(bugs)
|
Assignee | |
Comment 1•6 years ago
|
||
HasRetargetTouchTargets() checks mRetargetedTouchTargets.isSome() || mInitialTargetTouches.isSome()
Flags: needinfo?(bugs)
Attachment #8986016 -
Flags: review?(masayuki)
|
|
Assignee | |
Comment 2•6 years ago
|
||
A bit nicer place for the 'if'
Assignee: nobody → bugs
Attachment #8986016 -
Attachment is obsolete: true
Attachment #8986016 -
Flags: review?(masayuki)
Attachment #8986023 -
Flags: review?(masayuki)
|
||
Updated•6 years ago
|
Attachment #8986023 -
Flags: review?(masayuki) → review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4cde573c283a ensure mRetargetedTouchTargets has touch objects before using it, r=masayuki
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4cde573c283a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
|
||
Updated•6 years ago
|
status-firefox60:
--- → unaffected
status-firefox61:
--- → unaffected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•