59 bytes, text/x-review-board-request
Right now we have a XUL document that wraps the HTML document with an iframe. This is to support various features that don't work in top-level HTML windows (like size persistence, menus, etc). We are working through the list of these features in Bug 1460691, and once that is done we can remove the devtools.browserconsole.html pref and code to handle the 'false' case (including the browserconsole.xul document: https://searchfox.org/mozilla-central/rev/285da1fd7dcf67448b9175741fa330158edcff73/devtools/client/webconsole/browserconsole.xul#15)
I think there's a follow-up here around consolidating iframeWindow and chromeWindow throughout the devtools/client/webconsole (specifically BrowserConsole and WebConsole functions and there callers). Needs a bit more investigation around other callers so I'd rather do that in a separate bug.
Comment on attachment 8992967 [details] Bug 1469341 - Remove the XUL wrapper document for the Browser Console; https://reviewboard.mozilla.org/r/257796/#review264740 Nice cleanup ! As you said, it would be nice to see if we can get unify chromeWindow/iframeWindow in a follow-up.
Attachment #8992967 - Flags: review?(nchevobbe) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/3e792c898f69 Remove the XUL wrapper document for the Browser Console;r=nchevobbe
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.