1469341 - Remove the XUL wrapper document for the Browser Console

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Brian Grinstead [:bgrins]]

Right now we have a XUL document that wraps the HTML document with an iframe. This is to support various features that don't work in top-level HTML windows (like size persistence, menus, etc).

We are working through the list of these features in Bug 1460691, and once that is done we can remove the devtools.browserconsole.html pref and code to handle the 'false' case (including the browserconsole.xul document: https://searchfox.org/mozilla-central/rev/285da1fd7dcf67448b9175741fa330158edcff73/devtools/client/webconsole/browserconsole.xul#15)

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1469341 - Remove the XUL wrapper document for the Browser Console;

Review commit: https://reviewboard.mozilla.org/r/257796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257796/

Comment 2

[Brian Grinstead [:bgrins]]

I think there's a follow-up here around consolidating iframeWindow and chromeWindow throughout the devtools/client/webconsole (specifically BrowserConsole and WebConsole functions and there callers). Needs a bit more investigation around other callers so I'd rather do that in a separate bug.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8992967 [details]
Bug 1469341 - Remove the XUL wrapper document for the Browser Console;

https://reviewboard.mozilla.org/r/257796/#review264740

Nice cleanup ! As you said, it would be nice to see if we can get unify chromeWindow/iframeWindow in a follow-up.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e792c898f69
Remove the XUL wrapper document for the Browser Console;r=nchevobbe

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3e792c898f69