Remove the XUL wrapper document for the Browser Console

RESOLVED FIXED in Firefox 63

Status

enhancement
P3
normal
RESOLVED FIXED
10 months ago
8 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

(Depends on 1 bug)

unspecified
Firefox 63
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
Right now we have a XUL document that wraps the HTML document with an iframe. This is to support various features that don't work in top-level HTML windows (like size persistence, menus, etc).

We are working through the list of these features in Bug 1460691, and once that is done we can remove the devtools.browserconsole.html pref and code to handle the 'false' case (including the browserconsole.xul document: https://searchfox.org/mozilla-central/rev/285da1fd7dcf67448b9175741fa330158edcff73/devtools/client/webconsole/browserconsole.xul#15)
(Assignee)

Updated

10 months ago
Blocks: top-level-html
No longer blocks: 1460691
Depends on: 1460691, 1466897
(Assignee)

Updated

9 months ago
Depends on: 1456852
Comment hidden (mozreview-request)
(Assignee)

Comment 2

9 months ago
I think there's a follow-up here around consolidating iframeWindow and chromeWindow throughout the devtools/client/webconsole (specifically BrowserConsole and WebConsole functions and there callers). Needs a bit more investigation around other callers so I'd rather do that in a separate bug.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment on attachment 8992967 [details]
Bug 1469341 - Remove the XUL wrapper document for the Browser Console;

https://reviewboard.mozilla.org/r/257796/#review264740

Nice cleanup ! As you said, it would be nice to see if we can get unify chromeWindow/iframeWindow in a follow-up.
Attachment #8992967 - Flags: review?(nchevobbe) → review+

Comment 4

9 months ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e792c898f69
Remove the XUL wrapper document for the Browser Console;r=nchevobbe

Comment 5

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3e792c898f69
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63

Updated

8 months ago
Depends on: 1489140
You need to log in before you can comment on or make changes to this bug.