1469392 - UX: not all clickable items in the app provide button-like tap feedback

Status: NEW

(Firefox for iOS :: General, enhancement, P3)

Description

[:garvan]

We use custom labels, or tappable rows, to act like buttons and these don't provide standard button-like feedback to a tab (such as inverting or highlighting).

Examples:
- all the rows in our Photon menus
- buttons on the bottom toolbar like back, forward, and menu

Comment 1

[Robi]

On Firefox for iOS beta version 14.0 (12646), on Lowes.com pages some “links”/buttons do not fire.
Example:
https://www.lowes.com/pd/Zinsser-Ready-Patch-32-fl-oz-White-Patching-Compound/3851671
Between the Lowe’s logo and the login link there is the store “link” which is clickable but doesn’t fire or drop down...
Also the [check other stores] “button” looks like it reacts as a button (it highlights and depresses) but it doesn’t fire either.

Comment 2

[Justin D'Arcangelo [:justindarc]]

(In reply to Robi from comment #1)
> On Firefox for iOS beta version 14.0 (12646), on Lowes.com pages some
> “links”/buttons do not fire.
> Example:
> https://www.lowes.com/pd/Zinsser-Ready-Patch-32-fl-oz-White-Patching-
> Compound/3851671
> Between the Lowe’s logo and the login link there is the store “link” which
> is clickable but doesn’t fire or drop down...
> Also the [check other stores] “button” looks like it reacts as a button (it
> highlights and depresses) but it doesn’t fire either.

That's odd. I just tried the link you provided and everything seems to be functioning correctly.

Try going into Settings -> Data Management -> Website Data and search for "lowes.com" and delete all stored data (cookies, cache) for that site then try again to see if the problem persists.

If this still doesn't work, try disabling Tracking Protection for that website by tapping the "shield" icon in the address bar and then select "Disable for this site".

Comment 3

[Robi]

(In reply to Justin D'Arcangelo [:justindarc] from comment #2)

Thank you for your quick reply :)

[...]
> Try going into Settings -> Data Management -> Website Data and search for
> "lowes.com" and delete all stored data (cookies, cache) for that site then
> try again to see if the problem persists.

this didn't work :(

 
> If this still doesn't work, try disabling Tracking Protection for that
> website by tapping the "shield" icon in the address bar and then select
> "Disable for this site".

disabling the tracking protection worked partially...
The pop-up to select the sites (for both, "button" and drop-down link) worked, but selecting a new location doesn't change anything ...
on FF nightly (65.0a1 (2018-11-19) (32-bit)) it works as expected (with tracking protection enabled)

Comment 4

[Justin D'Arcangelo [:justindarc]]

Catalin, the issue described in Comment 1 and Comment 3 is unrelated to the purpose of this bug and I am unable to reproduce. However, would it be possible for you to double-check this and see if there is some issue here? Thanks!

Comment 5

[Catalin Suciu [:csuciu]]

I can't reproduce the issue mentioned in Comment 3 when tracking protection is disabled. When I press "Shop this store", the store gets selected correctly.

The issue described in Comment 1 can be reproduced with the default Tracking Protection settings.  
For this, since it's not related to the purpose of the original bug, I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1509280.