1469501 - TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:comm/calendar/test/unit/test_providers.js

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

This has popped up after re-enabling tests in bug 1457087.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1469501-disable-test.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d783a688319c
temporarily disable test_providers.js. rs=bustage-fix

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1469501-test-providers-1.diff

This is failing because the test framework won't call toString() when an object is provided as the test label. Since the information is redundant anyway, I've just removed it.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8988979 [details] [diff] [review]
1469501-test-providers-1.diff

Review of attachment 8988979 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/test/unit/head_consts.js
@@ -212,5 @@
>      }
>      for (let i = 0; i < aPropArray.length; i++) {
>          equal(getProps(aLeftItem, aPropArray[i]),
> -              getProps(aRightItem, aPropArray[i]),
> -              Components.stack.caller);

This is probably a leftover from before we used equal(). The idea was to augment the stack so it wouldn't show this function. Totally right to remove this!

Comment 5

[Jorg K (CEST = GMT+2)]

Nice, test passes with this patch. So *all* Calendar Xpcshell tests are online again. Now we're missing the real thing ;-)
Any idea where this problem regressed?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dcc96405a9ea
Fix broken test calendar/test/unit/test_providers.js. r=philipp

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8988979 [details] [diff] [review]
1469501-test-providers-1.diff

I hope there won't be too much opposition to uplifting this since most test were restored on TB 62, Cal 6.4, so this needs to join them.

Comment 8

[Jorg K (CEST = GMT+2)]

Beta (TB 62, Cal 6.4):
https://hg.mozilla.org/releases/comm-beta/rev/8b37d802b5c1224546e761007620ccdf8bd095d0
Fix broken test calendar/test/unit/test_providers.js. r=philipp a=test-only
Note that M-C have the policy that "test only" changes don't need special approval.

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to Jorg K (GMT+2) from comment #8)
> Note that M-C have the policy that "test only" changes don't need special
> approval.

This is fine for me in calendar as well.