Closed Bug 1469569 Opened 6 years ago Closed 5 years ago

Consolidate TextLogError and FailureLine models

Categories

(Tree Management :: Treeherder, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: ghickman, Unassigned)

References

(Blocks 1 open bug)

Details

Now that TextLogError and FailureLine are very similar in usage it would be ideal to have one model. However this is unlikely to be a trivial change: * Both tables have, in the range of, 20M rows and represent large disk usage * TextLogError's data is a superset of FailureLine's but might not exist when FailureLines are ingested Suggested Solution Create a way to identify both structured and unstructured logs such that an instance of one can be used to find the matching instance of the other. Upon ingestion of either log type we do an `update_or_create`. A concrete example: * we receive the structured log of <Job ID=6> * an identity function is run on this log * no matching log is found in the DB * we save a new Line row to the DB, <Line ID=15> * we receive the raw/unstructured log of <Job ID=6> * an identify function is run on this log * a matching Line is found in the DB, <Line ID=15>, and updated with the raw log data
Blocks: 1178227
Priority: -- → P3
Summary: Consolide TextLogError and FailureLine models → Consolidate TextLogError and FailureLine models

:Aryx I highly suspect your work will superseded these changes. Reopen if you think I am wrong.

Status: NEW → RESOLVED
Closed: 5 years ago
Component: Treeherder → Treeherder: Log Parsing & Classification
Flags: needinfo?(aryx.bugmail)
Resolution: --- → INVALID
Component: Treeherder: Log Parsing & Classification → TreeHerder
You need to log in before you can comment on or make changes to this bug.