Closed Bug 1469676 Opened Last year Closed Last year
sanity check task timeout definitions
46 bytes, text/x-phabricator-request
|Details | Review|
Some tasks have very long timeouts defined which expose bugs such as bug 1468926 where a task expired after 20 hours. We should re-evaluate the timeouts to ensure they are appropriate for each task.
The max-run-time for tasks appears to have been mostly cargo culted. In particular, a value of 36000 (10 hours) is quite absurd: no single task takes that long to execute. This commit reduces the max-run-time of several tasks to more reasonable values. The goal here is to prevent excessively long-running tasks. There is definitely room to further tweak values to further mitigate long-running tasks. But let's bite off the biggest chunk first, since that doesn't require much mental effort. There is a possibility I overshot on some of these tasks. If we get timeouts, we can always increase the timeout again.
Comment on attachment 8986293 [details] Bug 1469676 - Reduce max-run-time for various build tasks; r?glandium Mike Hommey [:glandium] has approved the revision. https://phabricator.services.mozilla.com/D1716
Attachment #8986293 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/5cc046f46541 Reduce max-run-time for various build tasks; r=glandium
Pushed by email@example.com: https://hg.mozilla.org/mozilla-central/rev/96399298b72f Reduce max-run-time for various build tasks: Increase Linux build max-run-time because they are pgo on beta. r=me a=beta-fix
You need to log in before you can comment on or make changes to this bug.