1469699 - The list creation script is expecting itisatracker.com to be present in disconnect_mapping.json

Status: ASSIGNED

(Cloud Services :: Server: Shavar, defect, P2)

Description

[François Marier [:francois]]

See https://github.com/mozilla-services/shavar-list-creation/pull/54#issuecomment-398539334 for the context.

I don't understand why the script is expecting the itisatracker.com entry to be present in the mapping since that entry is not in the Disconnect category, it's in Analytics:

https://github.com/mozilla-services/shavar-prod-lists/blob/f16248d7f33367bb3c48d72fb32fdb239dbe0c8e/disconnect-blacklist.json#L8204-L8210

Comment 1

[Luke Crouch [:groovecoder]]

Do you mean this assertion? https://github.com/mozilla-services/shavar-prod-lists/blob/master/scripts/json_verify.py#L240

Comment 2

[François Marier [:francois]]

That's probably the reason. I guess the assertion needs to be updated.

Comment 3

[Luke Crouch [:groovecoder]]

Does it? We added that to make sure that we don't accidentally merge a PR that removes itisatracker.com from the source .json file. The json_verify.py script only looks at the source files - not the mapped results. Is this breaking something? Or does it need to only check a single source file?

Comment 4

[François Marier [:francois]]

I'm not entirely what it's picking up here, but the reason I filed this bug is that whenever the script runs in prod, that error shows up in the logs that ckolos can see.

So it's either picking up something that is broken, or the assertion itself is triggered when it shouldn't. I think the intention is to not have this error present in the logs unless there is an actual problem.