Closed
Bug 1469790
Opened 6 years ago
Closed 6 years ago
Allow NEON autovectorization throughout the tree for NEON-required ARMv7 (e.g. Android)
Categories
(Firefox Build System :: Toolchains, enhancement)
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: hsivonen, Assigned: glandium)
Details
Attachments
(1 file)
According to bug 1397807 comment 17, we don't compile all C++ code with NEON enabled when compiling for ARMv7 Android despite only supporting Android devices that have NEON available. When Firefox is built with the assumption that NEON is unconditionally available, we might as well tell the compiler that NEON is available for all compilation units in case the autovectorizer manages to do something beneficial.
|
||
Comment 1•6 years ago
|
||
Snorp, do you have anyone on your team that might look at this?
Component: General → Toolchains
Flags: needinfo?(snorp)
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → mh+mozilla
Flags: needinfo?(snorp)
| Comment hidden (mozreview-request) |
|
||
Updated•6 years ago
|
Attachment #8988033 -
Flags: review?(core-build-config-reviews) → review?(nalexander)
|
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8988033 [details] Bug 1469790 - Build for NEON by default when targetting Android arm. https://reviewboard.mozilla.org/r/253286/#review260062 Sure.
Attachment #8988033 -
Flags: review?(nalexander) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/9d09683ea3d8 Build for NEON by default when targetting Android arm. r=nalexander
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9d09683ea3d8
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•5 years ago
|
Version: Version 3 → 3 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•