Closed
Bug 1469791
Opened 7 years ago
Closed 7 years ago
Use longer timeout for AcquireSync()
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
Details
Attachments
(1 file)
1.29 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
RenderDXGITextureHostOGL::Lock() and RenderDXGIYCbCrTextureHostOGL::Lock() use short timeout for IDXGIKeyedMutex::AcquireSync(). Another code like the following uses longer timeout. It seems better to use same timeout value.
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/d3d11/TextureD3D11.cpp#232
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/d3d11/TextureD3D11.cpp#1870
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•7 years ago
|
||
On my old win10 laptop, I often saw the timeout error log with current 100ms timeout.
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> On my old win10 laptop, I often saw the timeout error log with current 100ms
> timeout.
It is during youtube playback.
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8986402 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 4•7 years ago
|
||
We check device reset at RenderCompositorANGLE::BeginFrame(). Then longer device reset during Lock() should be OK.
Updated•7 years ago
|
Attachment #8986402 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 5•7 years ago
|
||
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06f179ea49cf
Use longer timeout for AcquireSync() r=nical
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•