1469791 - Use longer timeout for AcquireSync()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro OOO until July/21]]

RenderDXGITextureHostOGL::Lock() and RenderDXGIYCbCrTextureHostOGL::Lock() use short timeout for IDXGIKeyedMutex::AcquireSync(). Another code like the following uses longer timeout. It seems better to use same timeout value.

https://dxr.mozilla.org/mozilla-central/source/gfx/layers/d3d11/TextureD3D11.cpp#232
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/d3d11/TextureD3D11.cpp#1870

Comment 1

[Sotaro Ikeda [:sotaro OOO until July/21]]

On my old win10 laptop, I often saw the timeout error log with current 100ms timeout.

Comment 2

[Sotaro Ikeda [:sotaro OOO until July/21]]

(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> On my old win10 laptop, I often saw the timeout error log with current 100ms
> timeout.

It is during youtube playback.

Comment 3

[Sotaro Ikeda [:sotaro OOO until July/21]]

Attachment: patch - Use longer timeout for AcquireSync()

Comment 4

[Sotaro Ikeda [:sotaro OOO until July/21]]

We check device reset at RenderCompositorANGLE::BeginFrame(). Then longer device reset during Lock() should be OK.

Comment 5

[Sotaro Ikeda [:sotaro OOO until July/21]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f1afe8b1be60d0d9a2187ab5f9acdfee39670ef

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06f179ea49cf
Use longer timeout for AcquireSync() r=nical

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/06f179ea49cf