Closed Bug 1469791 Opened Last year Closed Last year

Use longer timeout for AcquireSync()

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

Details

Attachments

(1 file)

patch - Use longer timeout for AcquireSync()
1.29 KB, patch
nical
: review+
Details | Diff | Splinter Review 
RenderDXGITextureHostOGL::Lock() and RenderDXGIYCbCrTextureHostOGL::Lock() use short timeout for IDXGIKeyedMutex::AcquireSync(). Another code like the following uses longer timeout. It seems better to use same timeout value.

https://dxr.mozilla.org/mozilla-central/source/gfx/layers/d3d11/TextureD3D11.cpp#232
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/d3d11/TextureD3D11.cpp#1870
Assignee: nobody → sotaro.ikeda.g
On my old win10 laptop, I often saw the timeout error log with current 100ms timeout.
(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> On my old win10 laptop, I often saw the timeout error log with current 100ms
> timeout.

It is during youtube playback.
Attachment #8986402 - Flags: review?(nical.bugzilla)
We check device reset at RenderCompositorANGLE::BeginFrame(). Then longer device reset during Lock() should be OK.
Attachment #8986402 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06f179ea49cf
Use longer timeout for AcquireSync() r=nical
https://hg.mozilla.org/mozilla-central/rev/06f179ea49cf
Status: NEW → RESOLVED
Closed: Last year
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.