Closed Bug 1470041 Opened Last year Closed Last year

Add padding for liblibc musl support

Categories

(Core :: Audio/Video: cubeb, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: anarchy, Assigned: anarchy)

Details

Attachments

(1 file)

26:58.52    Compiling audioipc v0.2.1 (file:///var/tmp/portage/www-client/firefox-60.0/work/firefox-60.0/media/audioipc/audioipc)
26:59.51 error[E0063]: missing field `__pad1` in initializer of `libc::cmsghdr`
26:59.52    --> media/audioipc/audioipc/src/cmsg.rs:109:27
26:59.52     |
26:59.52 109 |             let cmsghdr = cmsghdr {
26:59.52     |                           ^^^^^^^ missing `__pad1`
26:59.52
27:00.56 error: aborting due to previous error

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9aff87bd6a19995c2a24cca74a4fc5cbf20554fc
:kinetik, can you please have a look at this patch? Thanks!
Assignee: nobody → anarchy
Status: NEW → ASSIGNED
Rank: 25
Flags: needinfo?(kinetik)
Priority: -- → P3
This is already fixed upstream: https://github.com/djg/audioipc-2/commit/1826cb7c7477cafa21212b577836ebee5244e1fe

We just need to update Gecko's import now.
(In reply to Matthew Gregan [:kinetik] from comment #2)
> This is already fixed upstream:
> https://github.com/djg/audioipc-2/commit/
> 1826cb7c7477cafa21212b577836ebee5244e1fe
> 
> We just need to update Gecko's import now.

Matthew would be nice if you could attach the patch here you applied. I would very much like this to be landed on esr branch and 62 if possible.
Categorizing based on readme for audioipc-2 project.
Component: Audio/Video → Audio/Video: cubeb
https://hg.mozilla.org/mozilla-central/rev/bdcf4ee0cea7
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
(In reply to Jory A. Pratt from comment #3)
> Matthew would be nice if you could attach the patch here you applied. I
> would very much like this to be landed on esr branch and 62 if possible.

Sorry for the delay.  The fix is on central now.  I'm not sure if it's something that'd be accepted for uplift, but if you want to make a case for it we can try.  The patch landed on central should be directly upliftable.
Flags: needinfo?(kinetik)
You need to log in before you can comment on or make changes to this bug.