Closed
Bug 1470073
Opened 7 years ago
Closed 7 years ago
Make IOActivityMonitor timer optional
Categories
(Core :: Networking, enhancement, P5)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: tarek, Assigned: tarek)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
The current mechanisme uses a timer to notify the data every n seconds.
For about:performance, we want to have the front end fetch the data explicitely to avoid having the timer run all the time even when the dashboard is not displayed.
IOActivityMonitor will be changed so it can be called explicitely via ChromeUtils
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8987012 [details]
Bug 1470073 - Make IOActivityMonitor timer optional -
https://reviewboard.mozilla.org/r/252264/#review259172
::: netwerk/base/IOActivityMonitor.cpp:502
(Diff revision 1)
> nsresult
> IOActivityMonitor::Shutdown_Internal()
> {
> mozilla::MutexAutoLock lock(mLock);
> + if (mInterval > 0) {
> - mTimer->Cancel();
> + mTimer->Cancel();
If (mInterval == 0) then mTimer will be null.
I think it would be better
```
if (mTimer) {
mTimer->Cancel()
}
```
::: netwerk/base/nsPISocketTransportService.idl:57
(Diff revision 1)
> - * I/O activity: we send out this topic no more than every
> - * intervalMilliseconds (as set by the
> - * "io.activity.intervalMilliseconds" preference: if 0 no notifications
> - * are sent) if the I/O is currently active (i.e. we're sending/receiving
> - * data to/from the socket or writing/reading to/from a file).
> + * I/O activity observer topic. Sends out information about the
> + * amount of data we're sending/receiving via sockets and disk files.
> + *
> + * Activated via the "io.activity.enabled" preference.
> + *
> + * when "io.activity.intervalMilliseconds" is > 0, automatically sends
nit: Trailing whitespaces.
::: netwerk/base/nsPISocketTransportService.idl:57
(Diff revision 1)
> - * I/O activity: we send out this topic no more than every
> - * intervalMilliseconds (as set by the
> - * "io.activity.intervalMilliseconds" preference: if 0 no notifications
> - * are sent) if the I/O is currently active (i.e. we're sending/receiving
> - * data to/from the socket or writing/reading to/from a file).
> + * I/O activity observer topic. Sends out information about the
> + * amount of data we're sending/receiving via sockets and disk files.
> + *
> + * Activated via the "io.activity.enabled" preference.
> + *
> + * when "io.activity.intervalMilliseconds" is > 0, automatically sends
nit: Trailing whitespaces.
::: netwerk/test/browser/browser_test_io_activity.js:38
(Diff revision 1)
> +}
> +
> +// this test activates the timer and checks the results as they come in
> +add_task(async function testWithTimer() {
> + SpecialPowers.setBoolPref("io.activity.enabled", true);
> + SpecialPowers.setIntPref("io.activity.intervalMilliseconds", 50);
nit: I think the best practice is to use SpecialPowers.pushPrefEnv
I don't mind it much, but it would be better if we could use that.
Attachment #8987012 -
Flags: review?(valentin.gosu) → review+
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 4•7 years ago
|
||
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8987012 [details]
Bug 1470073 - Make IOActivityMonitor timer optional -
https://reviewboard.mozilla.org/r/252264/#review259264
::: dom/chrome-webidl/ChromeUtils.webidl:355
(Diff revision 2)
> void requestPerformanceMetrics();
> +
> + /**
> + * Request IOActivityMonitor to send a notification containing I/O activity
> + */
> + void RequestIOActivity();
Is the upper case 'R' intentional here? Most other method names here start with a lowercase letter.
|
|
Assignee | |
Comment 6•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8987012 [details]
Bug 1470073 - Make IOActivityMonitor timer optional -
https://reviewboard.mozilla.org/r/252264/#review259264
> Is the upper case 'R' intentional here? Most other method names here start with a lowercase letter.
oops, unintentional, thanks
| Comment hidden (mozreview-request) |
Pushed by tziade@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5e89c1b4e8c
Make IOActivityMonitor timer optional - r=valentin
Backout by aiakab@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0292160da4fd
Backed out changeset b5e89c1b4e8c for failing browser chrome tests on browser_test_io_activity.js on a CLOSED TREE
|
||
Comment 10•7 years ago
|
||
Backed out changeset b5e89c1b4e8c (bug 1470073) for failing browser chrome tests on browser_test_io_activity.js on a CLOSED TREE
Backout revision https://hg.mozilla.org/integration/autoland/rev/0292160da4fdfaa8df3eda505921e194214871b4
Failed push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b5e89c1b4e8c18f72e2257e711dcc95704cff4da&filter-searchStr=tv
Link to a recent log: https://treeherder.mozilla.org/logviewer.html#?job_id=184795414&repo=autoland&lineNumber=10241
Part of that log: [task 2018-06-25T21:37:05.481Z] 21:37:05 INFO - TEST-START | netwerk/test/browser/browser_test_io_activity.js
[task 2018-06-25T21:37:05.483Z] 21:37:05 INFO - GECKO(3350) | Chrome file doesn't exist: /builds/worker/workspace/build/tests/mochitest/browser/netwerk/test/browser/head.js
[task 2018-06-25T21:37:05.652Z] 21:37:05 INFO - GECKO(3350) | ++DOCSHELL 0xe8dd5000 == 2 [pid = 3438] [id = {0a422640-e37a-49e3-b9b3-a5598d6b21bd}]
[task 2018-06-25T21:37:05.653Z] 21:37:05 INFO - GECKO(3350) | ++DOMWINDOW == 5 (0xf714d380) [pid = 3438] [serial = 7] [outer = (nil)]
[task 2018-06-25T21:37:05.781Z] 21:37:05 INFO - GECKO(3350) | ++DOMWINDOW == 6 (0xe92d4800) [pid = 3438] [serial = 8] [outer = 0xf714d380]
[task 2018-06-25T21:37:06.000Z] 21:37:05 INFO - GECKO(3350) | [Child 3438, Main Thread] WARNING: site security information will not be persisted: file /builds/worker/workspace/build/src/security/manager/ssl/nsSiteSecurityService.cpp, line 553
[task 2018-06-25T21:37:06.370Z] 21:37:06 INFO - GECKO(3350) | --DOMWINDOW == 2 (0xe834ee00) [pid = 3515] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:06.630Z] 21:37:06 INFO - GECKO(3350) | ++DOMWINDOW == 7 (0xe92d5e00) [pid = 3438] [serial = 9] [outer = 0xf714d380]
[task 2018-06-25T21:37:07.324Z] 21:37:07 INFO - GECKO(3350) | --DOCSHELL 0xcd8e0000 == 6 [pid = 3350] [id = {144d5feb-2234-4dcd-bd14-22d3ce00dd37}]
[task 2018-06-25T21:37:07.522Z] 21:37:07 INFO - GECKO(3350) | [Parent 3350, Main Thread] WARNING: NS_ENSURE_TRUE(aSecondURI) failed: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 98
[task 2018-06-25T21:37:07.826Z] 21:37:07 INFO - GECKO(3350) | --DOMWINDOW == 22 (0xf7149aa0) [pid = 3350] [serial = 7] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:07.826Z] 21:37:07 INFO - GECKO(3350) | --DOMWINDOW == 21 (0xd8080d90) [pid = 3350] [serial = 19] [outer = (nil)] [url = about:cache-entry?storage=disk&context=&eid=&uri=https://example.com/browser/netwerk/test/browser/dummy.html]
[task 2018-06-25T21:37:09.279Z] 21:37:09 INFO - GECKO(3350) | --DOMWINDOW == 6 (0xe8325000) [pid = 3438] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:09.281Z] 21:37:09 INFO - GECKO(3350) | --DOMWINDOW == 5 (0xe92d4400) [pid = 3438] [serial = 4] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:09.463Z] 21:37:09 INFO - TEST-INFO | started process screentopng
[task 2018-06-25T21:37:10.007Z] 21:37:10 INFO - TEST-INFO | screentopng: exit 0
[task 2018-06-25T21:37:10.008Z] 21:37:10 INFO - Buffered messages logged at 21:37:05
[task 2018-06-25T21:37:10.008Z] 21:37:10 INFO - Entering test bound testWithTimer
[task 2018-06-25T21:37:10.009Z] 21:37:10 INFO - Buffered messages finished
[task 2018-06-25T21:37:10.009Z] 21:37:10 INFO - TEST-UNEXPECTED-FAIL | netwerk/test/browser/browser_test_io_activity.js | Uncaught exception - wait for events to come in - timed out after 5 tries.
[task 2018-06-25T21:37:10.010Z] 21:37:10 INFO - Leaving test bound testWithTimer
[task 2018-06-25T21:37:10.011Z] 21:37:10 INFO - Entering test bound testWithManualCall
[task 2018-06-25T21:37:10.012Z] 21:37:10 INFO - GECKO(3350) | --DOMWINDOW == 8 (0xe84e8e00) [pid = 3537] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:10.013Z] 21:37:10 INFO - GECKO(3350) | --DOMWINDOW == 7 (0xe84e7c00) [pid = 3537] [serial = 5] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:10.015Z] 21:37:10 INFO - GECKO(3350) | ++DOCSHELL 0xe208f000 == 2 [pid = 3537] [id = {7fcc8e57-794b-4cdf-b02d-63712affca5f}]
[task 2018-06-25T21:37:10.016Z] 21:37:10 INFO - GECKO(3350) | ++DOMWINDOW == 8 (0xf714ec70) [pid = 3537] [serial = 10] [outer = (nil)]
[task 2018-06-25T21:37:10.020Z] 21:37:10 INFO - GECKO(3350) | ++DOMWINDOW == 9 (0xe84e7e00) [pid = 3537] [serial = 11] [outer = 0xf714ec70]
[task 2018-06-25T21:37:10.020Z] 21:37:10 INFO - GECKO(3350) | [Child 3537, Main Thread] WARNING: site security information will not be persisted: file /builds/worker/workspace/build/src/security/manager/ssl/nsSiteSecurityService.cpp, line 553
[task 2018-06-25T21:37:10.281Z] 21:37:10 INFO - GECKO(3350) | ++DOMWINDOW == 10 (0xe8ef6400) [pid = 3537] [serial = 12] [outer = 0xf714ec70]
[task 2018-06-25T21:37:10.782Z] 21:37:10 INFO - GECKO(3350) | --DOMWINDOW == 1 (0xf704d380) [pid = 3515] [serial = 1] [outer = (nil)] [url = https://example.com/browser/netwerk/test/browser/dummy.html]
[task 2018-06-25T21:37:11.695Z] 21:37:11 INFO - GECKO(3350) | --DOCSHELL 0xe4954000 == 1 [pid = 3537] [id = {8302d852-e705-4a51-950e-e0486f1c3c1c}]
[task 2018-06-25T21:37:11.695Z] 21:37:11 INFO - GECKO(3350) | --DOCSHELL 0xe8dd9800 == 1 [pid = 3438] [id = {3df3d676-039e-4ee0-8546-52cd45643f69}]
[task 2018-06-25T21:37:11.914Z] 21:37:11 INFO - TEST-PASS | netwerk/test/browser/browser_test_io_activity.js | A socket was used -
[task 2018-06-25T21:37:11.916Z] 21:37:11 INFO - TEST-PASS | netwerk/test/browser/browser_test_io_activity.js | A file was used -
[task 2018-06-25T21:37:11.917Z] 21:37:11 INFO - TEST-PASS | netwerk/test/browser/browser_test_io_activity.js | A sqlite DB was used -
[task 2018-06-25T21:37:11.918Z] 21:37:11 INFO - TEST-PASS | netwerk/test/browser/browser_test_io_activity.js | Every I/O event had data -
[task 2018-06-25T21:37:12.045Z] 21:37:12 INFO - Leaving test bound testWithManualCall
[task 2018-06-25T21:37:12.269Z] 21:37:12 INFO - GECKO(3350) | MEMORY STAT | vsize 958MB | residentFast 281MB | heapAllocated 77MB
[task 2018-06-25T21:37:12.273Z] 21:37:12 INFO - TEST-OK | netwerk/test/browser/browser_test_io_activity.js | took 6798ms
[task 2018-06-25T21:37:12.281Z] 21:37:12 INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-06-25T21:37:12.282Z] 21:37:12 INFO - TEST-UNEXPECTED-FAIL | netwerk/test/browser/browser_test_io_activity.js | Found an unexpected tab at the end of test run: http://example.com/ -
[task 2018-06-25T21:37:12.440Z] 21:37:12 INFO - GECKO(3350) | --DOMWINDOW == 9 (0xf714d380) [pid = 3537] [serial = 1] [outer = (nil)] [url = https://example.com/browser/netwerk/test/browser/dummy.html]
[task 2018-06-25T21:37:12.440Z] 21:37:12 INFO - GECKO(3350) | --DOMWINDOW == 8 (0xf714d710) [pid = 3537] [serial = 4] [outer = (nil)] [url = resource://gre/greprefs.js]
[task 2018-06-25T21:37:12.499Z] 21:37:12 INFO - GECKO(3350) | ++DOCSHELL 0xe2090000 == 2 [pid = 3537] [id = {40cccbcf-e331-42f9-ac2b-f26558f58cd4}]
[task 2018-06-25T21:37:12.499Z] 21:37:12 INFO - GECKO(3350) | ++DOMWINDOW == 9 (0xf714d380) [pid = 3537] [serial = 13] [outer = (nil)]
[task 2018-06-25T21:37:12.616Z] 21:37:12 INFO - GECKO(3350) | ++DOMWINDOW == 10 (0xe8486c00) [pid = 3537] [serial = 14] [outer = 0xf714d380]
[task 2018-06-25T21:37:12.640Z] 21:37:12 INFO - checking window state
[task 2018-06-25T21:37:12.696Z] 21:37:12 INFO - GECKO(3350) | --DOMWINDOW == 4 (0xf714d5e0) [pid = 3438] [serial = 5] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:12.793Z] 21:37:12 INFO - GECKO(3350) | ++DOMWINDOW == 22 (0xd1a46800) [pid = 3350] [serial = 24] [outer = 0xf7149970]
[task 2018-06-25T21:37:12.939Z] 21:37:12 INFO - GECKO(3350) | ++DOMWINDOW == 23 (0xddfbce00) [pid = 3350] [serial = 25] [outer = 0xf7149970]
[task 2018-06-25T21:37:13.897Z] 21:37:13 INFO - GECKO(3350) | --DOMWINDOW == 0 (0xe91cf800) [pid = 3515] [serial = 3] [outer = (nil)] [url = https://example.com/browser/netwerk/test/browser/dummy.html]
[task 2018-06-25T21:37:14.059Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 3 (0xe92d4600) [pid = 3438] [serial = 6] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:14.059Z] 21:37:14 INFO - GECKO(3350) | --DOCSHELL 0xe8dd5000 == 0 [pid = 3438] [id = {0a422640-e37a-49e3-b9b3-a5598d6b21bd}]
[task 2018-06-25T21:37:14.245Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 9 (0xe8ef8800) [pid = 3537] [serial = 9] [outer = (nil)] [url = resource://gre/greprefs.js]
[task 2018-06-25T21:37:14.246Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 8 (0xe8ef7c00) [pid = 3537] [serial = 8] [outer = (nil)] [url = resource://gre/]
[task 2018-06-25T21:37:14.246Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 7 (0xe8ef7000) [pid = 3537] [serial = 7] [outer = (nil)] [url = resource://gre/components/]
[task 2018-06-25T21:37:14.248Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 6 (0xe84ea200) [pid = 3537] [serial = 6] [outer = (nil)] [url = resource://gre/]
[task 2018-06-25T21:37:14.249Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 5 (0xe8ef5e00) [pid = 3537] [serial = 3] [outer = (nil)] [url = https://example.com/browser/netwerk/test/browser/dummy.html]
[task 2018-06-25T21:37:14.250Z] 21:37:14 INFO - GECKO(3350) | --DOCSHELL 0xe208f000 == 1 [pid = 3537] [id = {7fcc8e57-794b-4cdf-b02d-63712affca5f}]
[task 2018-06-25T21:37:14.613Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 3 (0xe8334800) [pid = 3483] [serial = 5] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:14.613Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 2 (0xf714d710) [pid = 3483] [serial = 4] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:14.613Z] 21:37:14 INFO - GECKO(3350) | --DOCSHELL 0xe413f400 == 0 [pid = 3483] [id = {729416db-9637-4462-997d-ed17b5d23788}]
[task 2018-06-25T21:37:14.633Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 2 (0xe92d5e00) [pid = 3438] [serial = 9] [outer = (nil)] [url = http://example.com/]
[task 2018-06-25T21:37:14.637Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 1 (0xe92d4800) [pid = 3438] [serial = 8] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:14.639Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 0 (0xf714d380) [pid = 3438] [serial = 7] [outer = (nil)] [url = http://example.com/]
[task 2018-06-25T21:37:14.884Z] 21:37:14 INFO - GECKO(3350) | --DOCSHELL 0xe91eac00 == 0 [pid = 3400] [id = {ab52c98d-6fe2-4058-a744-42e0f9582374}]
[task 2018-06-25T21:37:14.941Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 4 (0xe8ef6400) [pid = 3537] [serial = 12] [outer = (nil)] [url = http://example.com/]
[task 2018-06-25T21:37:14.941Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 3 (0xe84e7e00) [pid = 3537] [serial = 11] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:14.941Z] 21:37:14 INFO - GECKO(3350) | --DOMWINDOW == 2 (0xf714ec70) [pid = 3537] [serial = 10] [outer = (nil)] [url = http://example.com/]
[task 2018-06-25T21:37:15.250Z] 21:37:15 INFO - GECKO(3350) | --DOMWINDOW == 1 (0xf714d380) [pid = 3483] [serial = 6] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:15.250Z] 21:37:15 INFO - GECKO(3350) | --DOMWINDOW == 0 (0xe8335400) [pid = 3483] [serial = 7] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:15.691Z] 21:37:15 INFO - GECKO(3350) | --DOMWINDOW == 1 (0xf714a5e0) [pid = 3400] [serial = 5] [outer = (nil)] [url = about:newtab]
[task 2018-06-25T21:37:15.691Z] 21:37:15 INFO - GECKO(3350) | --DOMWINDOW == 0 (0xe83c7c00) [pid = 3400] [serial = 7] [outer = (nil)] [url = about:newtab]
[task 2018-06-25T21:37:16.196Z] 21:37:16 INFO - GECKO(3350) | --DOMWINDOW == 22 (0xf71c4200) [pid = 3350] [serial = 15] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:16.198Z] 21:37:16 INFO - GECKO(3350) | --DOMWINDOW == 21 (0xf71c8200) [pid = 3350] [serial = 12] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:16.202Z] 21:37:16 INFO - GECKO(3350) | --DOMWINDOW == 20 (0xf71cd600) [pid = 3350] [serial = 11] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:16.205Z] 21:37:16 INFO - GECKO(3350) | --DOMWINDOW == 19 (0xe5cc4600) [pid = 3350] [serial = 8] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:16.206Z] 21:37:16 INFO - GECKO(3350) | --DOMWINDOW == 18 (0xe48b3800) [pid = 3350] [serial = 23] [outer = (nil)] [url = about:cache-entry?storage=disk&context=&eid=&uri=https://example.com/browser/netwerk/test/browser/dummy.html]
[task 2018-06-25T21:37:16.208Z] 21:37:16 INFO - GECKO(3350) | --DOMWINDOW == 17 (0xd80a4200) [pid = 3350] [serial = 22] [outer = (nil)] [url = about:cache?storage=disk&context=]
[task 2018-06-25T21:37:16.209Z] 21:37:16 INFO - GECKO(3350) | --DOMWINDOW == 16 (0xddfbd000) [pid = 3350] [serial = 21] [outer = (nil)] [url = about:cache]
[task 2018-06-25T21:37:16.210Z] 21:37:16 INFO - GECKO(3350) | --DOMWINDOW == 15 (0xd80a3e00) [pid = 3350] [serial = 20] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:16.212Z] 21:37:16 INFO - GECKO(3350) | --DOMWINDOW == 14 (0xe48b2a00) [pid = 3350] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:17.120Z] 21:37:17 INFO - GECKO(3350) | --DOMWINDOW == 13 (0xf7173e00) [pid = 3350] [serial = 9] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:20.131Z] 21:37:20 INFO - GECKO(3350) | Completed ShutdownLeaks collections in process 3438
[task 2018-06-25T21:37:20.273Z] 21:37:20 INFO - GECKO(3350) | Completed ShutdownLeaks collections in process 3515
[task 2018-06-25T21:37:20.516Z] 21:37:20 INFO - GECKO(3350) | Completed ShutdownLeaks collections in process 3483
[task 2018-06-25T21:37:21.022Z] 21:37:21 INFO - GECKO(3350) | Completed ShutdownLeaks collections in process 3400
[task 2018-06-25T21:37:21.131Z] 21:37:21 INFO - GECKO(3350) | Completed ShutdownLeaks collections in process 3537
[task 2018-06-25T21:37:22.021Z] 21:37:22 INFO - GECKO(3350) | --DOMWINDOW == 12 (0xd1a46800) [pid = 3350] [serial = 24] [outer = (nil)] [url = about:blank]
[task 2018-06-25T21:37:26.988Z] 21:37:26 INFO - GECKO(3350) | Completed ShutdownLeaks collections in process 3350
[task 2018-06-25T21:37:26.989Z] 21:37:26 INFO - TEST-START | Shutdown
[task 2018-06-25T21:37:26.990Z] 21:37:26 INFO - Browser Chrome Test Summary
[task 2018-06-25T21:37:26.991Z] 21:37:26 INFO - Passed: 35
[task 2018-06-25T21:37:26.991Z] 21:37:26 INFO - Failed: 2
[task 2018-06-25T21:37:26.992Z] 21:37:26 INFO - Todo: 0
[task 2018-06-25T21:37:26.993Z] 21:37:26 INFO - Mode: e10s
[task 2018-06-25T21:37:26.994Z] 21:37:26 INFO - *** End BrowserChrome Test Results ***
Flags: needinfo?(tarek)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 12•7 years ago
|
||
Thanks and sorry. I did not get that specific timeout on my try calls.
I have changed the number of attempts and trying again on try on all platforms
Flags: needinfo?(tarek)
|
|
Assignee | |
Comment 13•7 years ago
|
||
|
|
Assignee | |
Comment 14•7 years ago
|
||
| Comment hidden (mozreview-request) |
|
||
Comment 16•7 years ago
|
||
Pushed by tziade@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39d47ffbb584
Make IOActivityMonitor timer optional - r=valentin
|
||
Comment 17•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•