Closed Bug 1470092 Opened 6 years ago Closed 6 years ago

Tecken: Support symbol file format change in upstream Breakpad (optional 'm' after FUNC or PUBLIC)

Categories

(Tecken :: General, task)

Product:
Tecken
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ted, Assigned: peterbe)

References

Details

Upstream Breakpad changed symbol files in a backwards-incompatible way: https://chromium.googlesource.com/breakpad/breakpad/+/b1226959a25b6a5311801d6f204b088c706e7c25 The change was to allow an optional m in FUNC and PUBLIC lines, immediately after the FUNC or PUBLIC part: https://chromium.googlesource.com/breakpad/breakpad/+/b1226959a25b6a5311801d6f204b088c706e7c25/docs/symbol_files.md#records-3 https://chromium.googlesource.com/breakpad/breakpad/+/b1226959a25b6a5311801d6f204b088c706e7c25/docs/symbol_files.md#records-4 It's included just to indicate "there were multiple symbol names pointing at this address", so for now just parsing lines that include it but ignoring it is fine.
gsvelto is trying to update our vendored copy of Breakpad in bug 1309172, so we'll need to fix this before that lands so we don't break the symbolication API. Looks like we need to change `SymbolicateJSON.load_symbol`: https://github.com/mozilla-services/tecken/blob/36df3eed2dcb86703a612b5560f56677a4fd4f80/tecken/symbolicate/views.py#L714
Moved to https://github.com/mozilla-services/tecken/issues/924
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
After some IRC chat we decided to move this ticket back into Bugzilla. Right now it's a PR here https://github.com/mozilla-services/tecken/pull/925
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
peterbe: assigning this to you since you fixed it in Tecken. Can you mark this FIXED when that change makes it to prod?
Assignee: nobody → peterbe
Component: Symbols → Tecken Integration
Bug 1309172 is ready to land so as soon as Tecken has this fix in production I'll land the changes to inbound.
Flags: needinfo?(peterbe)
The fix went into production as of 1 min ago.
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Flags: needinfo?(peterbe)
Resolution: --- → FIXED
Thanks a lot!

Moving from Socorro product to Tecken product.

Component: Tecken → General
Product: Socorro → Tecken
You need to log in before you can comment on or make changes to this bug.