Closed
Bug 1470162
Opened 7 years ago
Closed 7 years ago
Private Browsing mode style: no color changes, change only Tabs Icon by badging
Categories
(Firefox for iOS :: Theme & Visual Design, defect, P2)
Tracking
()
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 13.0 | --- |
People
(Reporter: garvan, Assigned: garvan)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Screenshot 2018-06-21 10.11.16.png
So as not to conflict with theme colors, PB mode will now only change the tabs icon with a badge indicating private mode.
Similar to the Themeable protocol, we should have
```
protocol PrivateThemeable {
func applyTheme(isPrivate: Bool)
}
```
Can you attach an icon for this? Thanks!
Flags: needinfo?(randersen)
We can check if the PB mode icon is scaleable to this small size, but I don't think we have anything small enough in the assets already.
|
||
Comment 5•7 years ago
|
||
Flags: needinfo?(randersen)
|
||
Updated•7 years ago
|
Priority: -- → P2
Attachment #8988286 -
Flags: review?(fpatel)
landed on master
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: qe-verify?
Resolution: --- → FIXED
|
|
||
Updated•7 years ago
|
Attachment #8988286 -
Flags: review?(fpatel) → review+
|
||
Comment 8•7 years ago
|
||
Verified as fixed on v13.0(11600)
Status: RESOLVED → VERIFIED
Flags: qe-verify?
You need to log in
before you can comment on or make changes to this bug.
Description
•