1470215 - add telemetry probe for how long native resolve requests sit in the thread-pool queues

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P1)

Description

[Daniel Stenberg [:bagder]]

A histogram for the time from the lookup call (which adds the request to a queue) until the request is subsequently removed from the queue by the thread that calls getaddrinfo().

Comment 1

[Daniel Stenberg [:bagder]]

Attachment: bug 1470215 let Telemetry::DNS_NATIVE_QUEUING measure queue times

Review commit: https://reviewboard.mozilla.org/r/252668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252668/

Comment 2

[Daniel Stenberg [:bagder]]

Should we rather use higher resolution than milliseconds in the histogram?

Comment 3

[Patrick McManus [:mcmanus]]

(In reply to Daniel Stenberg [:bagder] from comment #2)
> Should we rather use higher resolution than milliseconds in the histogram?

what would we do with such information?

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 8987430 [details]
bug 1470215 let Telemetry::DNS_NATIVE_QUEUING measure queue times

https://reviewboard.mozilla.org/r/252668/#review259184

data collection review too, of course.

Comment 5

[Daniel Stenberg [:bagder]]

Attachment: telemetry-native-queueing.txt

Request for data collection review: Telemetry::DNS_NATIVE_QUEUING

Comment 6

[François Marier [:francois]]

Comment on attachment 8987736 [details]
telemetry-native-queueing.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Daniel Stenberg.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default ON in all channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fafbc23c259
let Telemetry::DNS_NATIVE_QUEUING measure queue times r=mcmanus

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2fafbc23c259

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2fafbc23c259