Closed
Bug 1470284
Opened 6 years ago
Closed 6 years ago
New Tab Highlight card no image default colour is too light (Dark Theme)
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | verified |
People
(Reporter: amylee, Assigned: ahillier)
References
Details
Attachments
(2 files)
Reference.png
Hi,
The default fill colour for a Highlight card with no image is currently too light on Dark theme. Can you please change this to Grey 60 ##4a4a4f. See attached for reference
|
||
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/5f8e01392fa9f09267003a60e5af9f7b59300645
Bug 1470284 - Use a darker no-image colour for cards in dark theme (#4214)
|
||
Comment 3•6 years ago
|
||
Resolves with https://github.com/mozilla/activity-stream/commit/5f8e01392fa9f09267003a60e5af9f7b59300645
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Assignee: nobody → ahillier
Iteration: --- → 63.1 - July 9
Priority: -- → P1
|
|
||
Comment 4•6 years ago
|
||
status-firefox63:
--- → fixed
Target Milestone: --- → Firefox 63
|
||
Comment 5•6 years ago
|
||
I have verified that the issue is no longer reproducible on the latest Nightly (63.0a1) on Windows 10 x64, Mac 10.13.5 and Arch Linux x64.
|
||
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•