1470489 - Make pushlog and pushlog-legacy Mercurial 4.6 compatible

Status: RESOLVED FIXED

(Developer Services :: Mercurial: Pushlog, enhancement)

Comment 1

[Phabricator Automation]

Attachment: pushlog-legacy: specify error log file and print contents in test (Bug 1470489) r?gps

Similar to a few previous commits, this commit specifies an error
log file for each `hg serve` instance and prints the contents of
that file in the test output. This way any internal server errors
can be read in the test results.

Comment 2

[Phabricator Automation]

Attachment: pushlog-legacy: make compatible with Mercurial 4.6 (Bug 1470489) r?gps

This commit enables Mercurial 4.6 compatibility for the pushlog-legacy
extension. Most of the changes come from using the new `parsedrequest`
object and its attributes. `mercurial.obsstore.precursors` was also
renamed to `mercurial.obsstore.predecessors`.

Comment 3

[Phabricator Automation]

Attachment: pushlog: print error.log contents in tests (Bug 1470489) r?gps

Printing the error log of an `hg serve` process within the test
is useful for debugging when things like "500 Internal" errors
arise.

Comment 4

[Phabricator Automation]

Comment on attachment 8987168 [details]
pushlog-legacy: specify error log file and print contents in test (Bug 1470489) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D1774

Comment 5

[Phabricator Automation]

Comment on attachment 8987169 [details]
pushlog-legacy: make compatible with Mercurial 4.6 (Bug 1470489) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D1775

Comment 6

[Phabricator Automation]

Comment on attachment 8987170 [details]
pushlog: print error.log contents in tests (Bug 1470489) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D1776

Comment 7

[Phabricator Automation]

Attachment: pushlog: mark as 4.6 compatible (Bug 1470489) r?gps

After the changes to pushlog-legacy, the pushlog is compatible
with Mercurial 4.6 without making any changes. There were some
existing "# TRACKING hg46" comments which seem to have covered
all the breaking changes.

Comment 8

[Phabricator Automation]

Comment on attachment 8987173 [details]
pushlog: mark as 4.6 compatible (Bug 1470489) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D1778

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/d2093d1f0f25
pushlog-legacy: specify error log file and print contents in test r=gps

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/7c71a5f2ca7d
pushlog-legacy: make compatible with Mercurial 4.6 r=gps

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/0dd33d60b16a
pushlog: print error.log contents in tests r=gps

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/536fa31ce353
pushlog: mark as 4.6 compatible r=gps

Comment 13

[Connor Sheehan [:sheehan]]

Attachment: pushlog: append '/' to `url` pushlog template keyword in 4.6+ (Bug 1470489) r?gps

It turns out the conditional test output added in previous commits
for this bug was being generated due to the absence of a WSGI
config in the `hg serve` instances. This config usually sets a
`paths` config section, where local filesystem paths can be
mapped to a web url under which the repo should be served. For
example on hg.mo, we would map "/repo/hg/mozilla/" to "/",
so that "/repo/hg/mozilla/mozilla-unified" would appear as
"https://hg.mozilla.org/mozilla-unified" as a web facing
url. This commit adds a `wsgiconfig` function to generate
a config file which can be passed to the `hg serve` instance
via the `--web-conf` option.

As a result of this change, all urls referencing the serve
instance without the local repo name have had the repo name
appended (ie "https://localhost:$HGPORT" is now
"https://localhost:$HGPORT/reponame").

After making this change, I noticed that the base URL on 4.6.2
no longer ended with a '/', which caused links to revisions and
other resources to 404. This commit also fixes this by appending
'/' to the variable that is later seeded into the `url` template
keyword when running on 4.6+.

Comment 14

[Phabricator Automation]

Comment on attachment 8993749 [details]
pushlog: append '/' to `url` pushlog template keyword in 4.6+ (Bug 1470489) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D2270

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/4274c7f6a43d
pushlog: append '/' to `url` pushlog template keyword in 4.6+ r=gps