Closed Bug 1470608 Opened 2 years ago Closed 2 years ago

Remove "custom-strings.txt" support, along with nsIStringBundleOverride and related code

Categories

(Core :: Internationalization, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: kmag, Assigned: kmag)

Details

Attachments

(1 file)

The string bundle override code adds a lot of complexity to the string bundle service, and doesn't appear to offer a lot of gain. I also can't find any evidence that it's used anymore, outside of Thunderbird.
Assignee: nobody → kmaglione+bmo
Priority: -- → P3
Jorg - how hard would it be to remove those calls from Thunderbird?
Flags: needinfo?(jorgk)
(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #2)
> Jorg - how hard would it be to remove those calls from Thunderbird?

What calls?

When I say "outside of Thunderbird", I mean that when I googled, I found some references to people using it in Thunderbird. Thunderbird itself doesn't seem to care about it.
If I understand the question correctly, this is about the removal of nsIStringBundleOverride. That's not used in TB. As Kris pointed out, some people talk about custom-strings.txt on the net, for example here:
http://forums.mozillazine.org/viewtopic.php?f=39&t=2941025
There seems to be some connection to the popular QuickText add-on now maintained by John and Philippe, so I'll CC them here.

I see no problem removing this functionality.
Flags: needinfo?(jorgk)
I could not find a reference to "nsIStringBundleOverride" in the current quicktext sources. Also not for "Services.strings.", so it looks like quicktext is not using that.
Comment on attachment 8987323 [details]
Bug 1470608: Remove StringBundleOverride service.

https://reviewboard.mozilla.org/r/252576/#review259530

Thank you all! And thank you Kris for cleaning up 16 y/old code! lgtm! :)
Attachment #8987323 - Flags: review?(gandalf) → review+
https://hg.mozilla.org/mozilla-central/rev/07535136756a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.