1470608 - Remove "custom-strings.txt" support, along with nsIStringBundleOverride and related code

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P3)

Description

[Kris Maglione [:kmag]]

The string bundle override code adds a lot of complexity to the string bundle service, and doesn't appear to offer a lot of gain. I also can't find any evidence that it's used anymore, outside of Thunderbird.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1470608: Remove StringBundleOverride service.

Review commit: https://reviewboard.mozilla.org/r/252576/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252576/

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Jorg - how hard would it be to remove those calls from Thunderbird?

Comment 3

[Kris Maglione [:kmag]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #2)
> Jorg - how hard would it be to remove those calls from Thunderbird?

What calls?

When I say "outside of Thunderbird", I mean that when I googled, I found some references to people using it in Thunderbird. Thunderbird itself doesn't seem to care about it.

Comment 4

[Jorg K (CEST = GMT+2)]

If I understand the question correctly, this is about the removal of nsIStringBundleOverride. That's not used in TB. As Kris pointed out, some people talk about custom-strings.txt on the net, for example here:
http://forums.mozillazine.org/viewtopic.php?f=39&t=2941025
There seems to be some connection to the popular QuickText add-on now maintained by John and Philippe, so I'll CC them here.

I see no problem removing this functionality.

Comment 5

[John Bieling (:TbSync)]

I could not find a reference to "nsIStringBundleOverride" in the current quicktext sources. Also not for "Services.strings.", so it looks like quicktext is not using that.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8987323 [details]
Bug 1470608: Remove StringBundleOverride service.

https://reviewboard.mozilla.org/r/252576/#review259530

Thank you all! And thank you Kris for cleaning up 16 y/old code! lgtm! :)

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07535136756a8fe7d2671a40e1761d580d26b6bb
Bug 1470608: Remove StringBundleOverride service. r=gandalf

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/07535136756a