Remove "custom-strings.txt" support, along with nsIStringBundleOverride and related code

RESOLVED FIXED in Firefox 63

Status

()

P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
The string bundle override code adds a lot of complexity to the string bundle service, and doesn't appear to offer a lot of gain. I also can't find any evidence that it's used anymore, outside of Thunderbird.
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Assignee: nobody → kmaglione+bmo
Priority: -- → P3
Jorg - how hard would it be to remove those calls from Thunderbird?
Flags: needinfo?(jorgk)
(Assignee)

Comment 3

9 months ago
(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #2)
> Jorg - how hard would it be to remove those calls from Thunderbird?

What calls?

When I say "outside of Thunderbird", I mean that when I googled, I found some references to people using it in Thunderbird. Thunderbird itself doesn't seem to care about it.

Comment 4

9 months ago
If I understand the question correctly, this is about the removal of nsIStringBundleOverride. That's not used in TB. As Kris pointed out, some people talk about custom-strings.txt on the net, for example here:
http://forums.mozillazine.org/viewtopic.php?f=39&t=2941025
There seems to be some connection to the popular QuickText add-on now maintained by John and Philippe, so I'll CC them here.

I see no problem removing this functionality.
Flags: needinfo?(jorgk)

Comment 5

9 months ago
I could not find a reference to "nsIStringBundleOverride" in the current quicktext sources. Also not for "Services.strings.", so it looks like quicktext is not using that.

Comment 6

9 months ago
mozreview-review
Comment on attachment 8987323 [details]
Bug 1470608: Remove StringBundleOverride service.

https://reviewboard.mozilla.org/r/252576/#review259530

Thank you all! And thank you Kris for cleaning up 16 y/old code! lgtm! :)
Attachment #8987323 - Flags: review?(gandalf) → review+

Comment 8

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/07535136756a
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.