1470731 - Crash in java.lang.IllegalArgumentException: Service not registered: org.mozilla.gecko.process.GeckoProcessManager$ChildConnection@<addr>: at android.app.LoadedApk.forgetServiceDispatcher(LoadedApk.java)

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Julian Seward [:jseward]]

This bug was filed from the Socorro interface and is
report bp-11e0c764-af32-446e-b9ed-5b8910180623.
=============================================================

This is topcrash #5 in the Android nightly 20180621100051, with
13 crashes in 6 different installations.

Top 10 frames of crashing thread:

0 libxul.so void mozilla::jni::Accessor::EndAccess<mozilla::java::AndroidGamepadManager::OnGamepadAdded_t> 
1 libxul.so int mozilla::jni::Method<mozilla::java::GeckoProcessManager::Start_t, int>::Call<mozilla::jni::StringParam, mozilla::jni::Ref<mozilla::jni::TypedObject<_jobjectArray*>, _jobjectArray*>, int, int, int, int> widget/android/jni/Accessors.h:99
2 libxul.so mozilla::java::GeckoProcessManager::Start widget/android/GeneratedJNIWrappers.cpp:2364
3 libxul.so mozilla::ipc::GeckoChildProcessHost::LaunchAndroidService ipc/glue/GeckoChildProcessHost.cpp:1267
4 libxul.so mozilla::ipc::GeckoChildProcessHost::PerformAsyncLaunchInternal ipc/glue/GeckoChildProcessHost.cpp:821
5 libxul.so mozilla::ipc::GeckoChildProcessHost::PerformAsyncLaunch ipc/glue/GeckoChildProcessHost.cpp:543
6 libxul.so mozilla::ipc::GeckoChildProcessHost::RunPerformAsyncLaunch ipc/glue/GeckoChildProcessHost.cpp:551
7 libxul.so decltype  xpcom/threads/nsThreadUtils.h:1165
8 libxul.so mozilla::detail::RunnableMethodImpl<mozilla::ipc::GeckoChildProcessHost*, bool  xpcom/threads/nsThreadUtils.h:1171
9 libxul.so MessageLoop::RunTask ipc/chromium/src/base/message_loop.cc:451

=============================================================

Comment 1

[Marcia Knous [:marcia]]

I saw a bunch more similar signatures while looking at today's nightly data - https://bit.ly/2yU2L0G has some of them. Most of them are single crash signatures.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1470731 - Don't try to unbind child process service if we aren't bound

Review commit: https://reviewboard.mozilla.org/r/254276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254276/

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8989233 [details]
Bug 1470731 - Don't try to unbind child process service if we aren't bound

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/254276/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec8a2d909be9
Don't try to unbind child process service if we aren't bound r=droeh

Comment 5

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8989233 [details]
Bug 1470731 - Don't try to unbind child process service if we aren't bound

https://reviewboard.mozilla.org/r/254276/#review261338

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ec8a2d909be9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8989233 [details]
Bug 1470731 - Don't try to unbind child process service if we aren't bound

Approval Request Comment
[Feature/Bug causing the regression]: Unknown
[User impact if declined]: Crashes
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Adds a trivial guard
[String changes made/needed]: None

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8989233 [details]
Bug 1470731 - Don't try to unbind child process service if we aren't bound

Crash fix, low risk, Beta62+

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ff703785d55d