1470824 - Sync Network throttling UI buttons

Status: RESOLVED DUPLICATE of bug 1531642

(DevTools :: Netmonitor, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Network throttling UI is now available on two places:

* RDM
* Network panel

We agreed that it makes sense to have this UI on both places, but we should also make sure that it stays in sync.

STR:

1) Open DevTools Toolbox, select the Network panel
2) Click the "Responsive Design Mode" button in Toolbox's Toolbar
3A) Change throttling in RDM View and see that the Network panel's throttling button isn't updated -> BUG
3B) Change throttling in Network panel toolbar and see that RDM View throttling button isn't updated -> BUG

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@jryans: do you have any tips how to fix this for anyone interested in fixing this bug?

Honza

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Hmm.  This is actually more complex than just the UI.

Since RDM and the toolbox can each be toggle independently of each other, RDM currently makes its own separate connection to the server.  This means that if you have both RDM and toolbox open, there are two separate instances of each actor (2 emulation actors, 2 console actors, etc.) active simultaneously.  If someone were to set both throttling menus, the throttling would actually compound for 2x slowdown!

So for a rough sketch:

1. Change RDM and toolbox to share targets / connections so there's only one set of actors (bug 1471307)
2. Change the emulation front to emit a client-side event when throttling changes (so that both UIs can update)

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Razvan, you were working on this in different bug recently. Should we close/dup this one?

Honza

Comment 4

[Razvan Caliman [:rcaliman]]

Yes, this is a duplicate of bug 1531642. I will close it.

Comment #2 was foretelling the complexity I encountered on bug 1531642. I am still working on that, but it does indeed depend on bug 1471307 and changing how the RDM and Toolbox connect to the server so they no longer have separate instances of actors.