1470828 - privacy.resistFingerprinting breaks some shortcut keys

Status: NEW

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Gary Chen [:xeonchen]]

STR:

1. enable privacy.resistFingerprinting
2. open a Google Doc document, insert some text
3. use keyboard shortcut to switch to next tab (on mac: cmd-shift-])

Expected Result:
tab focus changes to next tab without modifying the document

Actual Result:
tab focus changed to next tab, but the focused line in the document was indented.

Comment 1

[Ethan Tseng [:ethan]]

(In reply to Gary Chen [:xeonchen] use needinfo? please from comment #0)
> 3. use keyboard shortcut to switch to next tab (on mac: cmd-shift-])

The default shortcut of switching to the next tab on MacOS is [Ctrl+Tab], isn't it?

Comment 2

[Gary Chen [:xeonchen]]

(In reply to Ethan Tseng [:ethan] from comment #1)
> (In reply to Gary Chen [:xeonchen] use needinfo? please from comment #0)
> > 3. use keyboard shortcut to switch to next tab (on mac: cmd-shift-])
> 
> The default shortcut of switching to the next tab on MacOS is [Ctrl+Tab],
> isn't it?

There are several ways[1] to switch tab, although the shortcut I reported is not listed,
but I know it works, and Safari/Chrome also support this key binding.

I don't remember how I learned this from, but it must be something wrong in the keyboard event dispatching.
So this might be a good way to observe the behavior.


[1] https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly

Comment 3

[Ethan Tseng [:ethan]]

(In reply to Gary Chen [:xeonchen] use needinfo? please from comment #2)
> There are several ways[1] to switch tab, although the shortcut I reported is
> not listed,
> but I know it works, and Safari/Chrome also support this key binding.
I see.
I often use the shortcut [Cmd+Num] to switch to a certain tab as well.
Yes, let's investigate and fix it.

Comment 4

[Tim Huang[:timhuang]]

I think the UI shortcut key will always send to the content. The root cause of this problem is that we strip keyboard modifiers when RFP is enabled. And this striped event is exactly the same as the shortcut of indenting document in Google doc. In my opinion, maybe we can resolve this by adding a whitelist of keyboard shortcuts that we can safely send modifiers and it won't leak the keyboard layout.

Comment 5

[Ethan Tseng [:ethan]]

This issue was caused by the fingerprinting protection implemented by bug 1222285.

Comment 6

[Tim Huang[:timhuang]]

Unassign myself because I am no longer actively working on this.

Comment 7

[Luke]

RFP also breaks keyboard shortcuts used by userscripts (confirmed in Violentmoneky)