Open Bug 1470828 Opened 2 years ago Updated 1 year ago

privacy.resistFingerprinting breaks some shortcut keys

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P2)

defect

Tracking

()

People

(Reporter: xeonchen, Assigned: timhuang)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fingerprinting][fp-triaged])

STR:

1. enable privacy.resistFingerprinting
2. open a Google Doc document, insert some text
3. use keyboard shortcut to switch to next tab (on mac: cmd-shift-])

Expected Result:
tab focus changes to next tab without modifying the document

Actual Result:
tab focus changed to next tab, but the focused line in the document was indented.
(In reply to Gary Chen [:xeonchen] use needinfo? please from comment #0)
> 3. use keyboard shortcut to switch to next tab (on mac: cmd-shift-])

The default shortcut of switching to the next tab on MacOS is [Ctrl+Tab], isn't it?
(In reply to Ethan Tseng [:ethan] from comment #1)
> (In reply to Gary Chen [:xeonchen] use needinfo? please from comment #0)
> > 3. use keyboard shortcut to switch to next tab (on mac: cmd-shift-])
> 
> The default shortcut of switching to the next tab on MacOS is [Ctrl+Tab],
> isn't it?

There are several ways[1] to switch tab, although the shortcut I reported is not listed,
but I know it works, and Safari/Chrome also support this key binding.

I don't remember how I learned this from, but it must be something wrong in the keyboard event dispatching.
So this might be a good way to observe the behavior.


[1] https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly
(In reply to Gary Chen [:xeonchen] use needinfo? please from comment #2)
> There are several ways[1] to switch tab, although the shortcut I reported is
> not listed,
> but I know it works, and Safari/Chrome also support this key binding.
I see.
I often use the shortcut [Cmd+Num] to switch to a certain tab as well.
Yes, let's investigate and fix it.
Priority: -- → P2
Whiteboard: [fingerprinting-breakage] → [fingerprinting]
I think the UI shortcut key will always send to the content. The root cause of this problem is that we strip keyboard modifiers when RFP is enabled. And this striped event is exactly the same as the shortcut of indenting document in Google doc. In my opinion, maybe we can resolve this by adding a whitelist of keyboard shortcuts that we can safely send modifiers and it won't leak the keyboard layout.
Assignee: nobody → tihuang
Summary: privacy.resistFingerprinting sends UI shortcut key to web content → privacy.resistFingerprinting breaks some shortcut keys
Whiteboard: [fingerprinting] → [fingerprinting][fp-triaged]
This issue was caused by the fingerprinting protection implemented by bug 1222285.
Blocks: 1222285
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.