1470944 - Crash when running mse changeType wpt

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

STR:
Set media.mediasource.experimental.enabled
Go to http://w3c-test.org/media-source/mediasource-changetype.html

crash

null deref

Now bug 1470814 fixed that issue, but there's still problem in the ordering of tasks.

Comment 1

[Phabricator Automation]

Attachment: Bug 1470944 - Don't attempt to create a new demuxer upon changeType call

Re-creating a new demuxer is fine, provided that the SourceBufferResource exists. However, a resource is only created upon receiving an init segment.

The segment following a call to changeType() must be an init segment, will let the demuxer creation occurs there.

Comment 2

[Phabricator Automation]

Comment on attachment 8987581 [details]
Bug 1470944 - Don't attempt to create a new demuxer upon changeType call

Bryce Van Dyk (:bryce) has approved the revision.

https://phabricator.services.mozilla.com/D1812

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ff64c686d51
Don't attempt to create a new demuxer upon changeType call r=bryce

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/7ff64c686d51

Comment 5

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 63.0a1 (BuildId:20180625220119) on Windows 10 64bit.

This issue is verified fixed using Firefox 63.0b7 (BuildId:20180917143811) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 16.04 64bit.