1471018 - Crash in shutdownhang | __psynch_cvwait | <name omitted> | mozilla::dom::quota::QuotaManager::ShutdownObserver::Observe

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect, P2)

Description

[Gabriele Svelto [:gsvelto]]

This bug was filed from the Socorro interface and is
report bp-098f98e8-3018-47d7-8cee-8c70a0180625.
=============================================================

Top 10 frames of crashing thread:

0 libsystem_kernel.dylib __psynch_cvwait 
1 libmozglue.dylib <name omitted> mozglue/misc/ConditionVariable_posix.cpp:118
2 XUL mozilla::ThreadEventQueue<mozilla::PrioritizedEventQueue<mozilla::EventQueue> >::GetEvent xpcom/threads/CondVar.h:66
3 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:983
4 XUL NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:519
5 XUL mozilla::dom::quota::QuotaManager::ShutdownObserver::Observe xpcom/threads/nsThreadUtils.h:324
6 XUL nsObserverList::NotifyObservers xpcom/ds/nsObserverList.cpp:112
7 XUL nsObserverService::NotifyObservers xpcom/ds/nsObserverService.cpp:295
8 XUL nsXREDirProvider::DoShutdown toolkit/xre/nsXREDirProvider.cpp:1067
9 XUL ScopedXPCOMStartup::~ScopedXPCOMStartup toolkit/xre/nsAppRunner.cpp:1396

=============================================================

Comment 1

[Marion Daly [:mdaly]]

Janv: Investigate

Comment 2

[Jan Varga [:janv]]

Jeez, we never set mShutdownRequested in AsmJSCache.cpp, so it can happen that ShutdownWorkThreads runs for too long.

Comment 3

[Jan Varga [:janv]]

Attachment: patch

Comment 4

[Jan Varga [:janv]]

Attachment: [mq]: asmjscache, manually landed, so the phabricator revision was marked abandoned.

patch

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8999578 [details]
[mq]: asmjscache, manually landed, so the phabricator revision was marked abandoned.

Andrew Sutherland [:asuth] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f32468900cd
Speed-up AsmJSCache shutdown by setting the shutdown requested flag; r=asuth

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0f32468900cd

Comment 8

[Ryan VanderMeulen [:RyanVM]]

We should probably nominate this for Beta approval since that's where the crash reports seem to be coming from.

Comment 9

[Jan Varga [:janv]]

I've got a beta approval ready for submitting, will send it tomorrow or so.

Comment 10

[Jan Varga [:janv]]

Comment on attachment 8999578 [details]
[mq]: asmjscache, manually landed, so the phabricator revision was marked abandoned.

Approval Request Comment
[Feature/Bug causing the regression]: 1389561
[User impact if declined]: Users may experience browser crashes during shutdown.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Very low risk.
[Why is the change risky/not risky?]: The patch is very simple and the old asm.js caching is not used so much (it has been replaced with WebAssembly).
[String changes made/needed]: None.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8999578 [details]
[mq]: asmjscache, manually landed, so the phabricator revision was marked abandoned.

Crash fix, looks very low volume on beta 62 but let's take it for uplift to beta 19.

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/cfe8e60f9e0a

Comment 13

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8999578 [details]
[mq]: asmjscache, manually landed, so the phabricator revision was marked abandoned.

Andrew Sutherland [:asuth] has been removed from the revision.

Comment 14

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8999578 [details]
[mq]: asmjscache, manually landed, so the phabricator revision was marked abandoned.

The last 2 changes were because I wanted to close out the phabricator review so it got off the home screen.  I couldn't figure out how to mark it as externally landed so I commandeered it and abandoned it.