1471027 - Crash in xul.dll@0x5f3b62 | static struct style::media_queries::media_list::MediaList style::media_queries::media_list::MediaList::parse

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-39d810a0-81e0-4228-a740-ba5890180623.
=============================================================

Seen while looking at crash stats - crashes look to have started using 20180619102337: https://bit.ly/2Irj2K2. Looks like about 11 crashes since it started, various flavors of Windows.

Possible regression window based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f804cc575bba9c6dcb4e3770f7dafe4d8934e73c&tochange=e429320fcdd2d5236bb4713e6c435456146e42b9

Top 10 frames of crashing thread:

0 xul.dll xul.dll@0x5f3b62 
1 xul.dll static struct style::media_queries::media_list::MediaList style::media_queries::media_list::MediaList::parse servo/components/style/media_queries/media_list.rs:58
2 xul.dll void geckoservo::glue::Servo_MediaList_SetText servo/ports/geckolib/glue.rs:3762
3 xul.dll mozilla::dom::MediaList::SetTextInternal layout/style/MediaList.cpp:115
4 xul.dll mozilla::dom::MediaList::Create layout/style/MediaList.cpp:95
5 xul.dll mozilla::dom::MediaQueryList::MediaQueryList layout/style/MediaQueryList.cpp:30
6 xul.dll nsIDocument::MatchMedia dom/base/nsDocument.cpp:6436
7 xul.dll nsGlobalWindowOuter::MatchMediaOuter dom/base/nsGlobalWindowOuter.cpp:3499
8 xul.dll nsGlobalWindowInner::MatchMedia dom/base/nsGlobalWindowInner.cpp:3532
9 xul.dll static bool mozilla::dom::WindowBinding::matchMedia dom/bindings/WindowBinding.cpp:3025

=============================================================

Comment 1

[Mike Taylor [:miketaylr]]

Any ideas here Emilio?

Comment 2

[[:philipp]]

perhaps a continuation/signature change from bug 1448868?

Comment 3

[Maire Reavy [:mreavy]]

(In reply to [:philipp] from comment #2)
> perhaps a continuation/signature change from bug 1448868?

Emilio, Cameron -- shall we dup this to bug 1448868 (which is believed to be a dup of OOM_SMALL)?  It looks like the volume has increased.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Yeah, this is an OOM. The "regressing" bug is bug 1468846, which moved the parse_media_query_list function to MediaList::parse.

Regarding what to do here, we could try to avoid the Latin1 -> UTF16 -> UTF8 string conversion from the DOM bindings. Nika, I remember Boris, you and I discussed such a thing during the all hands (having a UTF8 string in the bindings for stylo). Do you know if there's a bug for that?

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Found it :)

Comment 7

[Pascal Chevrel:pascalc]

Almost all crashes disappeared with 63 and we don't have crashes in pre-release versions so it's likely that the signature changed, maybe this is now the one in bug 1508617?

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Since the crash volume is low (less than 5 per week), the severity is downgraded to S3. Feel free to change it back if you think the bug is still critical.

For more information, please visit auto_nag documentation.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.