Closed Bug 1471132 Opened Last year Closed Last year

Change how static xpcom components are linked/initialized

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr60 --- fixed
firefox63 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(5 files)

No description provided.
Comment on attachment 8987744 [details]
Bug 1471132 - Make building a binary component a compile-time error.

https://reviewboard.mozilla.org/r/253016/#review259668
Attachment #8987744 - Flags: review?(nfroyd) → review+
Comment on attachment 8987743 [details]
Bug 1471132 - Change how static xpcom components are initialized.

https://reviewboard.mozilla.org/r/253014/#review259672
Attachment #8987743 - Flags: review?(nfroyd) → review+
Comment on attachment 8987741 [details]
Bug 1471132 - Avoid ASAN padding between NSModules.

https://reviewboard.mozilla.org/r/253010/#review259676
Attachment #8987741 - Flags: review?(nfroyd) → review+
Comment on attachment 8987742 [details]
Bug 1471132 - Change how static xpcom components are linked.

https://reviewboard.mozilla.org/r/253012/#review259690

::: toolkit/library/moz.build
(Diff revision 2)
> -SOURCES += [
> -    'StaticXULComponentsStart.cpp',
> -]
> -
> -# This, combined with the fact the file is first, makes the start pointer
> -# it contains first in Windows PGO builds.
> -SOURCES['StaticXULComponentsStart.cpp'].no_pgo = True
> -
> -# Don't let LTO reorder StaticXULComponentsStart.o.
> -for f in CONFIG['OS_CXXFLAGS']:
> -    if f.startswith('-flto'):
> -        SOURCES['StaticXULComponentsStart.cpp'].flags += ['-fno-lto']
> -        break
> -

So nice to get rid of this.
Attachment #8987742 - Flags: review?(nfroyd) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 480ea315a847ffb63a8cb1e583669a61f1a7f3eb -d 9f4d1a4296ba: rebasing 469902:480ea315a847 "Bug 1471132 - Avoid ASAN padding between NSModules. r=froydnj"
rebasing 469903:de968c61dc4e "Bug 1471132 - Change how static xpcom components are linked. r=froydnj"
rebasing 469904:1a32c95312d8 "Bug 1471132 - Change how static xpcom components are initialized. r=froydnj"
rebasing 469905:cc224240c4f7 "Bug 1471132 - Make building a binary component a compile-time error. r=froydnj"
rebasing 469906:c6259994c6c0 "Bug 1447116 - Update builders to rust 1.28. r=froydnj"
merging taskcluster/ci/toolchain/windows.yml
warning: conflicts while merging taskcluster/ci/toolchain/windows.yml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/dfd0afd7b60f
Avoid ASAN padding between NSModules. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/7839040f0d42
Change how static xpcom components are linked. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/32d574a02a2e
Change how static xpcom components are initialized. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/b7873993686f
Make building a binary component a compile-time error. r=froydnj
No longer blocks: macOS-PGO

Comment on attachment 9035860 [details] [diff] [review]
Bug 1471132 - Handle 3-column nm/readelf output in check_binary r=glandium (esr60)

This is one of series of patches I am requesting uplift to esr60. Please don't uplift any if the entire series won't go. The whole series will need to go in one push.

This try run (applied on tip-of-esr60 as of an hour ago; and beginning with 'Bug 1491901 - move MK*SHLIB to moz.configure') represents the patch series. It must be applied in that order: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0659d6e265f3b624ad6fbac0c9cd7ce246094596 (If this try run doesn't complete successfully, I will investigate and figure out why)

The uplift request form is the same for all of the patch series; see https://bugzilla.mozilla.org/show_bug.cgi?id=1491901#c10

Attachment #9035860 - Flags: approval-mozilla-esr60?

Comment on attachment 9035860 [details] [diff] [review]
Bug 1471132 - Handle 3-column nm/readelf output in check_binary r=glandium (esr60)

approved for 60.5esr

Attachment #9035860 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.