1471165 - Bypass binding restrictions preventing the use of optional dictionaries with required arguments

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Jean-Yves Avenard [:jya]]

MediaCapabilities (introduced in bug 1409664) spec make use of optional dictionaries, each of those dictionaries having required members.

Per bug 1368949, further discussed in https://github.com/heycam/webidl/issues/76 having a required member in a dictionary, prevent that dictionary to be optional.

While waiting for an agreement to be found on how to best handle this in the binding, in the mean time, let's implement the spec behaviour in code.

Comment 1

[Phabricator Automation]

Attachment: Bug 1471165 - P1. Simulate required MediaCapabilities members in optional dictionary. r?bz

In order to allow for optional dictionaries with required members
See https://github.com/heycam/webidl/issues/76 for more information.

Comment 2

[Phabricator Automation]

Attachment: Bug 1471165 - P2. Add logging facilities. r?bryce

Comment 3

[Phabricator Automation]

Attachment: Bug 1471165 - P3. Update web-platform-tests results. r?bryce

There are two tests failing:
Test that decodingInfo rejects if the video configuration contentType has more than one parameter
and
Test that decodingInfo rejects if the audio configuration contentType has more than one parameter

Our nsContentTypeParser doesn't provide an ability to count the nomber of parameters, only to retrieve one if the name is known.

Considering the scope of the extra work, we'll leave it as-is for now

Comment 4

[Phabricator Automation]

Comment on attachment 8987910 [details]
Bug 1471165 - P2. Add logging facilities. r?bryce

Bryce Van Dyk (:bryce) has approved the revision.

https://phabricator.services.mozilla.com/D1834

Comment 5

[Phabricator Automation]

Comment on attachment 8987911 [details]
Bug 1471165 - P3. Update web-platform-tests results. r?bryce

Bryce Van Dyk (:bryce) has approved the revision.

https://phabricator.services.mozilla.com/D1835

Comment 6

[Phabricator Automation]

Attachment: Bug 1471165 - P4. run clang-format on MediaCapabilities. r?bryce

Somehow clang-format produces different output on mac than with the default version on windows, so run-it again.

Depends on D1835

Comment 7

[Phabricator Automation]

Comment on attachment 8988238 [details]
Bug 1471165 - P4. run clang-format on MediaCapabilities. r?bryce

Bryce Van Dyk (:bryce) has approved the revision.

https://phabricator.services.mozilla.com/D1848

Comment 8

[Phabricator Automation]

Comment on attachment 8987908 [details]
Bug 1471165 - P1. Simulate required MediaCapabilities members in optional dictionary. r?bz

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D1833

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f1d5e7ef244
P1. Simulate required MediaCapabilities members in optional dictionary. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/6571ee61f0aa
P2. Add logging facilities. r=bryce
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf624413028d
P3. Update web-platform-tests results. r=bryce

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3f1d5e7ef244
https://hg.mozilla.org/mozilla-central/rev/6571ee61f0aa
https://hg.mozilla.org/mozilla-central/rev/bf624413028d

Comment 11

[Boris Zbarsky [:bzbarsky]]

Is there a followup, depending on bug 1368949, to realign with the spec idl here?

Comment 12

[Jean-Yves Avenard [:jya]]

there is not...

Comment 13

[Boris Zbarsky [:bzbarsky]]

Could you please get one on file, with a summary of what needs to happen?