1471258 - JITed functions don't have a signature; and thus can't be checked by cfi-icall

Status: NEW

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

When we JIT out a function and call it there is no signature during compilation for CFI's icall check to do anything intelligent. So we need to disable icall at that callsite.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1471258 Disable CFI icall at JIT function entry points

Review commit: https://reviewboard.mozilla.org/r/253178/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253178/

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8987891 [details]
Bug 1471258 Disable CFI icall at JIT function entry points

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253178/diff/1-2/

Comment 3

[Nicolas B. Pierron [:nbp]]

Tom, did you meant to ask someone for a review, or is the patch not yet ready for review?

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

(In reply to Nicolas B. Pierron [:nbp] {backlog: 39} from comment #3)
> Tom, did you meant to ask someone for a review, or is the patch not yet
> ready for review?

It could be reviewed for sanity certainly; but I haven't asked anyone for review yet because I don't intend to land it until I have a lot of other pieces in place.

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8987891 [details]
Bug 1471258 Disable CFI icall at JIT function entry points

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253178/diff/2-3/