1471347 - stop using std::string/stringstreams in profiler code

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P1)

Description

[Nathan Froyd [:froydnj]]

Using operator<< and friends from the standard library requires locale-specific
formatting, which requires registry calls on Windows.  We can do better.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - store an nsCString for SharedLibrary::mVersion

Using operator<< on stringstream on Windows dives into the registry for
locale-specific formatting details.  This behavior is neither desired
or (probably) anticipated by the code.  Instead, let's use our normal
Gecko string classes for SharedLibrary::mVersion.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - store an nsCString for SharedLibrary::mBreakpadId

Similar to the previous part, we convert mBreakpadId to an nsCString to
avoid issues with locale-dependent std::string operations.

There are a lot of non-profiler changes here because a bunch of things
depend on the SharedLibrary object that the profiler defines.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8987944 [details] [diff] [review]
part 2 - store an nsCString for SharedLibrary::mBreakpadId

Review of attachment 8987944 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/core/shared-libraries-linux.cc
@@ +70,5 @@
> +
> +  nsCString uuid;
> +  const std::string str = FileID::ConvertIdentifierToUUIDString(aIdentifier);
> +  uuid.Append(str.c_str(), str.size());
> +  uuid.Append('0');

'\0'?

Comment 4

[Markus Stange [:mstange]]

'0' is correct: this is the "breakpad id age" which is set to the pdbAge on Windows and to zero on non-Windows.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Is this ready to land?

Comment 6

[Nathan Froyd [:froydnj]]

Yes; I'm going to add a comment to avoid the confusion from comment 3.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b7ad73f1f43
part 1 - store an nsCString for SharedLibrary::mVersion; r=njn
https://hg.mozilla.org/integration/mozilla-inbound/rev/aadd0e8ef250
part 2 - store an nsCString for SharedLibrary::mBreakpadId; r=njn

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6b7ad73f1f43
https://hg.mozilla.org/mozilla-central/rev/aadd0e8ef250