147135 - missing cell border (inset "light" color too light)

Status: NEW

(Core :: Layout, defect)

Description

[Dave Dyer]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.0rc2) Gecko/20020510
BuildID:    1,0 pr2 

the right and bottom cell borders are missing for 
the main tables on the referenced page. It looks
very strange without them.

Reproducible: Always
Steps to Reproduce:
1. just view the page
2.
3.

Comment 1

[Henri Sivonen (:hsivonen)]

The table cells are missing in the markup. That's why they don't show up. I
didn't find anything in the relevant specs (HTML 4.01 and CSS2) saying that
missing cells should be handled in any particular way.

Resolving as INVALID. Please reopen if you can cite a W3C specification that
says the missing cells should be automatically generated.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Um... There is nothing missing in the markup.  And the table borders are
present.  They are just very light.  The site does not specify the border color
and it looks like our inset borders are a lot lighter on the "light" side than
IE's are.

Reopening to consider changing that.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Confirming.

Comment 4

[Henri Sivonen (:hsivonen)]

Sorry, I misread the description and thought this was about the borders of the
entirely missing cells on the bottom right side of the large tables.

Comment 5

[Laura Krietemeyer]

Changing QA Contact

Comment 6

[Kevin McCluskey (gone)]

Reassigning to Don.

Comment 7

[Boris Zbarsky [:bzbarsky]]

One note.  IE's implementation makes the colors far too dark if the border 
color and the background color are set to the same value.  In that case it is 
usually hard to tell that the cell is actually inset.  In Mozilla, one can tell 
with no trouble...

In other words, I'm not convinced we want to change this behavior.

Comment 8

[Koike Kazuhiko]

Another testcase:
http://bugzilla.mozilla.gr.jp/showattachment.cgi?attach_id=945

Screenshot:
http://bugzilla.mozilla.gr.jp/showattachment.cgi?attach_id=946

Comment 9

[Boris Zbarsky [:bzbarsky]]

.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I cannot reproduce this on 2006012105-trunk/WinXP.

-> WFM

Comment 11

[Boris Zbarsky [:bzbarsky]]

This is still an issue.  Note that this is a code-level issue -- the site may be changed but the issue of border darkness or lightness is still present.

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Could you create a testcase?

Comment 13

[Boris Zbarsky [:bzbarsky]]

As it happens, the page in the URL bar shows it nicely.

A similar issue with outset borders happens on http://web.mit.edu/bzbarsky/www/index.shtml except I hacked around the differences with CSS that IE6 and earlier do not support.  See the comments on the border colors in http://web.mit.edu/bzbarsky/www/Styles/screen.css

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thanks, Boris.
I understand. We(Bugzilla-jp) were misreading this bug, sorry.
Should we change NS_Get3DColors and NS_GetSpecial3DColors like IE?
http://lxr.mozilla.org/mozilla/source/layout/base/nsCSSColorUtils.cpp
# Ah, and is this a "normal" bug? looks like "enchancement".

Comment 15

[Boris Zbarsky [:bzbarsky]]

Well, we may just want to wontfix this, really.  I don't know how much of a problem it really is in practice...