1471366 - Crash in [@ CrashReporter::TerminateHandler | std::__terminate][@ nsColorPicker::GetHexStringFromNSColor]

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This bug was filed from the Socorro interface and is
report bp-0fa1b1fc-dbe2-4bd1-9f6f-f6cff0180626.
=============================================================

Top 10 frames of crashing thread:

0 XUL CrashReporter::TerminateHandler toolkit/crashreporter/nsExceptionHandler.cpp:1435
1 libc++abi.dylib std::__terminate 
2 libc++abi.dylib __cxa_throw 
3 libobjc.A.dylib objc_exception_throw 
4 CoreFoundation +[NSException raise:format:] 
5 XUL nsColorPicker::GetHexStringFromNSColor widget/cocoa/nsColorPicker.mm:140
6 XUL -[NSColorPanelWrapper colorChanged:] widget/cocoa/nsColorPicker.mm:170
7 AppKit -[NSApplication sendAction:to:from:] 
8 AppKit __61-[NSColorPanel _forceSendAction:notification:firstResponder:]_block_invoke 
9 AppKit -[NSColorPanel _withColorSettingDisabled:] 

=============================================================

Comment 1

[Mike Taylor [:miketaylr]]

jwatt, it seems your patch regressed this -- can you take a look?

Comment 2

[[:philipp]]

this is a socorro query covering just the particular color picker issue:
https://crash-stats.mozilla.com/signature/?product=Firefox&proto_signature=~GetHexStringFromNSColor&signature=CrashReporter%3A%3ATerminateHandler%20%7C%20std%3A%3A__terminate&date=%3E%3D2018-03-01#reports

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 62, while this color picker issue isn't a big top crash, it is new in 62 and should be fixable.

Comment 4

[Stephen A Pohl [:spohl] (OOO until 2/27)]

This is due to the linker flags added in bug 1289847, and most likely due to an SDK switch thereafter that made it no longer possible for our code to catch and handle exceptions raised by native code. This could be manifesting in a number of odd crashes because our code used to handle a number of possible native exceptions. We should prioritize the work in bug 1290972 as soon as possible. I have confirmed locally that removing these linker flags allows our code to handle native exceptions again.

Comment 6

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Bug 1290972 just landed, which fixes this.

Comment 7

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Bug 1290972 has been uplifted to 62.