1471379 - [skiplist] Add "CrashReporter::TerminateHandler | std::__terminate" to the skiplist (bug 1467582)

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Stephen A Pohl [:spohl]]

We should add "CrashReporter::TerminateHandler | std::__terminate" (and any other necessary frames) to the skiplist to better differentiate the crashes that currently aggregate in bug 1467582. This is similar to what was done in bug 1410580 for SIGABRT crashes.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is marked as critical and blocking a bug that appears to be resolved, so I'm a little confused.

Does this need to get done today? We don't do deploys during release week because of the risks in deploys, but if it's super critical and really a P1, we can figure it out.

Comment 2

[Stephen A Pohl [:spohl]]

No, this doesn't have that high of a priority. It was automatically set to P1 because I cloned bug 1410580 for it. I went ahead and adjusted the priority. Thanks for confirming!

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

No problem! Thank you for clarifying!

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Alexis: Do you want to try out a signature generation bug? There's instructions on using the command line and how to make changes to the lists here:

https://socorro.readthedocs.io/en/latest/signaturegeneration.html

Comment 5

[Alexis Deschamps [:alexisdeschamps]]

OK, I can try.

Comment 6

[Alexis Deschamps [:alexisdeschamps]]

`CrashReporter::TerminateHandler` was already in the prefix list.
I could add `std::__terminate`, `__cxa_throw`, and `objc_begin_catch` to the prefix list. This would be results using the crash IDs I found in bug 1467582:

https://crash-stats.mozilla.com/report/index/4943e3d5-4e4a-4c83-b627-a41330180606
Original: CrashReporter::TerminateHandler | std::__terminate
New:      CrashReporter::TerminateHandler | std::__terminate | __cxa_throw | objc_begin_catch | CFPasteboardPromiseDataUsingBlock
Same?:    False

https://crash-stats.mozilla.com/report/index/6bc014b5-0799-47c5-8e1f-4fd3c0180620
Crash id: 6bc014b5-0799-47c5-8e1f-4fd3c0180620
Original: CrashReporter::TerminateHandler | std::__terminate
New:      CrashReporter::TerminateHandler | std::__terminate | __cxa_throw | objc_begin_catch | CFPasteboardPromiseDataUsingBlock
Same?:    False

https://crash-stats.mozilla.com/report/index/f88469be-860d-4688-aff2-ff0330180626
Original: CrashReporter::TerminateHandler | std::__terminate
New:      CrashReporter::TerminateHandler | std::__terminate | __cxa_throw | objc_begin_catch | -[NSMutableArray replaceObjectsInRange:withObjectsFromSet:]
Same?:    False

Would this be suitable?

Otherwise, some of `CrashReporter::TerminateHandler`, `std::__terminate`, `__cxa_throw`, and `objc_begin_catch` could be added to the skip list.

Comment 7

[Stephen A Pohl [:spohl]]

(In reply to Alexis Deschamps [:alexisdeschamps] from comment #6)
> Otherwise, some of `CrashReporter::TerminateHandler`, `std::__terminate`,
> `__cxa_throw`, and `objc_begin_catch` could be added to the skip list.

Yes, I think these should all be added as they don't help much in differentiating the different types of crashes that we're seeing.

Thank you for looking into this!

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/587f029fa5501e45ddda90cf25018e3c530fb953
fix bug 1471379: updated signature lists

- moved CrashReporter::TerminateHandler from the prefix to the irrelevant list
- added `__cxa_throw` to the irrelevant list
- added `objc_begin_catch` to the irrelevant list
- added `std::__terminate` to the irrelevant list

https://github.com/mozilla-services/socorro/commit/854e1f169fa9d22bd5244d3d288f8df2af1e44c4
Merge pull request #4504 from mozilla-services/signature-generation

fix bug 1471379: updated signature lists